This repository was archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
fix($parse): treat falsy values as defined in assignment expressions #14990
Milestone
Comments
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Aug 6, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Aug 6, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Aug 6, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Aug 8, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Aug 10, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Aug 11, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Aug 11, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Sep 9, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Sep 10, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Sep 10, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Sep 10, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Sep 10, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Sep 10, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Sep 11, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Sep 11, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Sep 11, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Sep 11, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Sep 11, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Oct 10, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Oct 10, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Oct 10, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Oct 10, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Oct 10, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Oct 10, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Oct 10, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Oct 10, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Oct 10, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Oct 10, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Oct 11, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Oct 11, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Oct 11, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Oct 11, 2016
m-amr
added a commit
to m-amr/angular.js
that referenced
this issue
Oct 11, 2016
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this issue
Mar 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Do you want to request a feature or report a bug?
Bug.
What is the current behavior?
When Angular
$parse
s an assignment expression - e.g.'foo.toFixed = "bar"'
- it treats falsy values as if they don't exist in the context and overwrites them. I.e.:If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://plnkr.co or similar (template: http://plnkr.co/edit/tpl:yBpEi4).
What is the expected behavior?
Falsy values should be treated as defined (the same as truthy values).
What is the motivation / use case for changing the behavior?
Doing the right thing 😃
Which versions of Angular, and which browser / OS are affected by this issue? Did this work in previous versions of Angular? Please also test with the latest stable and snapshot (https://code.angularjs.org/snapshot/) versions.
All browsers.
I tested on Angular v1.5.8 and snapshot.
Other information (e.g. stacktraces, related issues, suggestions how to fix)
As suggested by @lgalfaso, the calls to
self.not(...)
should be replaced withself.notNull(...)
at appropriate places (such as here and there).The text was updated successfully, but these errors were encountered: