fix($parse): treat falsy values as defined in assignment expressions

Closes angular#14990
Closes angular#14994

Author: m-amr

src/ng/parse.js

@@ -1042,7 +1042,7 @@ ASTCompiler.prototype = {
           self.if_(self.stage === 'inputs' || 's', function() {
             if (create && create !== 1) {
               self.if_(
-                self.not(self.nonComputedMember('s', ast.name)),
+                self.isNull(self.nonComputedMember('s', ast.name)),
                 self.lazyAssign(self.nonComputedMember('s', ast.name), '{}'));
             }
             self.assign(intoId, self.nonComputedMember('s', ast.name));
@@ -1079,7 +1079,7 @@ ASTCompiler.prototype = {
           } else {
             ensureSafeMemberName(ast.property.name);
             if (create && create !== 1) {
-              self.if_(self.not(self.nonComputedMember(left, ast.property.name)), self.lazyAssign(self.nonComputedMember(left, ast.property.name), '{}'));
+              self.if_(self.isNull(self.nonComputedMember(left, ast.property.name)), self.lazyAssign(self.nonComputedMember(left, ast.property.name), '{}'));
             }
             expression = self.nonComputedMember(left, ast.property.name);
             if (self.state.expensiveChecks || isPossiblyDangerousMemberName(ast.property.name)) {
@@ -1274,6 +1274,10 @@ ASTCompiler.prototype = {
     return '!(' + expression + ')';
   },
 
+  isNull: function(expression) {
+    return expression + '==null';
+  },
+
   notNull: function(expression) {
     return expression + '!=null';
   },
@@ -1705,7 +1709,7 @@ ASTInterpreter.prototype = {
   identifier: function(name, expensiveChecks, context, create, expression) {
     return function(scope, locals, assign, inputs) {
       var base = locals && (name in locals) ? locals : scope;
-      if (create && create !== 1 && base && !(base[name])) {
+      if (create && create !== 1 && base && base[name] == null) {
         base[name] = {};
       }
       var value = base ? base[name] : undefined;
@@ -1749,7 +1753,7 @@ ASTInterpreter.prototype = {
       var lhs = left(scope, locals, assign, inputs);
       if (create && create !== 1) {
         ensureSafeAssignContext(lhs);
-        if (lhs && !(lhs[right])) {
+        if (lhs && lhs[right] == null) {
           lhs[right] = {};
         }
       }

test/ng/parseSpec.js

@@ -3059,7 +3059,7 @@ describe('parser', function() {
           // foo.constructor is not a constructor.
           expect(function() {
             delete scope.foo;
-            scope.$eval('foo.constructor[0] = ""', {foo: {constructor: ''}});
+            scope.$eval('foo.constructor[0] = ""', {foo: {constructor: {}}});
           }).not.toThrow();
 
           expect(function() {
@@ -3176,7 +3176,7 @@ describe('parser', function() {
           // foo.constructor.prototype is not a constructor prototype.
           expect(function() {
             delete scope.foo;
-            scope.$eval('foo.constructor.prototype[0] = ""', {foo: {constructor: {prototype: ''}}});
+            scope.$eval('foo.constructor.prototype[0] = ""', {foo: {constructor: {prototype: {}}}});
           }).not.toThrow();
         });
       });
@@ -3900,6 +3900,45 @@ describe('parser', function() {
           expect(isFunction(s.toString)).toBe(true);
           expect(l.toString).toBe(1);
         }));
+
+        it('should assign a property to scope properties with null or undefined value', inject(function($parse) {
+          var scope = {a:null};
+          $parse("a.b =1")(scope);
+          expect(scope.a).toEqual({b:1});
+
+          scope.a = undefined;
+          $parse("a.b =1")(scope);
+          expect(scope.a).toEqual({b:1});
+        }));
+
+        they('should not assign a property to scope properties with $prop value', [0, false, ''],
+          function(falsyValue) {
+            inject(function($parse) {
+              var scope = {a:falsyValue};
+              expect(function() {
+                $parse("a.b=1")(scope);
+              }).toThrow();
+              expect(scope.a).toBe(falsyValue);
+
+              scope = {a:falsyValue};
+              expect(function() {
+                $parse("a['b']=1")(scope);
+              }).toThrow();
+              expect(scope.a).toBe(falsyValue);
+
+              scope = {a:{b:falsyValue}};
+              expect(function() {
+                $parse("a.b.c=1")(scope);
+              }).toThrow();
+              expect(scope.a.b).toBe(falsyValue);
+
+              scope = {a:{b:falsyValue}};
+              expect(function() {
+                $parse("a.b['c']=1")(scope);
+              }).toThrow();
+              expect(scope.a.b).toBe(falsyValue);
+            });
+          });
       });
 
       describe('literal', function() {