Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

element.toggleClass does not accept a function #12793

Closed
philBrown opened this issue Sep 9, 2015 · 0 comments
Closed

element.toggleClass does not accept a function #12793

philBrown opened this issue Sep 9, 2015 · 0 comments
Labels
component: jqLite severity: confusing
Milestone
Ice Box

Comments

@philBrown
Copy link
Contributor

Either update toggleClass to be compatible with jQuery 1.4 and accept a function or note in the angular.element docs that it is not compatible with that method signature.

Running toggleClass with a function at the moment produces

TypeError: selector.split is not a function

due to the assumption that the first argument, if present, is a string.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: jqLite severity: confusing
Projects
None yet
Milestone
Ice Box
Development

Successfully merging a pull request may close this issue.

fix(jqLite) - toggleClass & removeClass reflect documentation
2 participants
@philBrown @Narretz