Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

jqLite - removeClass cannot accept a function #12851

Closed
JordanMajd opened this issue Sep 14, 2015 · 2 comments
Closed

jqLite - removeClass cannot accept a function #12851

JordanMajd opened this issue Sep 14, 2015 · 2 comments

Comments

@JordanMajd
Copy link

Angular documentation redirects to jQuery 1.4, which states that removeClass should be able to take a function as a parameter. Also they state that if no parameter is provided removeClass should remove all classes.

This is currently not the case.

I am submitting a pull request to fix this issue.

@gkalpak
Copy link
Member

gkalpak commented Sep 15, 2015

It's not jQuery 1.4, it's the latest 1.x jQuery (currently 1.9).

That said, there seems to be indeed a difference between the add/removeClass() signatures/behaviour.
I'm not sure if we should just document it, or if it's worth implementing.
(If we do implement it, we have to be consistent with the jQuery implementation though.)

@JordanMajd
Copy link
Author

You are correct, I misspoke: the ability to pass in functions or no parameters was introduced in jQuery 1.4 but we need it to be compliant with the the latest version.

#12852 should fix this in a manner that is consistent with the jQuery implementation.

@Narretz Narretz added this to the Backlog milestone Oct 27, 2015
@Narretz Narretz closed this as completed in cd3673e Jun 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants