-
Notifications
You must be signed in to change notification settings - Fork 27.4k
ngHide documentation could use a little whitespace #10101
Comments
Hmm, the indentation spaces are somehow getting lost in the markdown -> HTML conversion process as it looks alright in the source code: angular.js/src/ng/directive/ngShowHide.js Lines 45 to 53 in 4d4e603
@petebacondarwin do you remember, from to of your head, which part of the doc generation pipeline is responsible for this conversion? |
No it doesn't look alright. There is no whitespace in the source |
@petebacondarwin are we talking about the same white-spaces? I meant the ones responsible for indentation, like this one: angular.js/src/ng/directive/ngShowHide.js Line 48 in 4d4e603
|
@pkozlowski-opensource - right I see now. I thought you meant the lack of space between the words, rather than the indentation. This is a bug in dgeni. I'll fix it. |
… kill the indentation Previously we were trying to be clever and guess that lines that had zero indentation were actually just rolling over from the previous line and so were ignored. But since we ignore the first line if it has no indentation, we had to rely on the second line having no indentation for the zero indentation to be set. If the second line had indentation then all future zero indentation lines were being ignored. This change now never ignores zero indent lines and so will indent most things properly. If a line is rolling over then it should be indented to the minimum level already for it to be displayed correctly. See angular/angular.js#10101
Also a problem in ngCloak: https://docs.angularjs.org/api/ng/directive/ngCloak |
Now it has indentation, but if you look at what I suggested, it was more than indentation, but also whitespace after the CSS attribute names. It is still missing that. |
That is a simple change in the src code. |
Fixed in 16c8f29 |
ngHide shows a CSS block withallthewhitespaceremoved:
With minification tools readily available, we should be writing CSS examples for readability, not for minimization:
There is another block that looks like this:
which I suggest would read better as:
The text was updated successfully, but these errors were encountered: