fix(base/trimIndentation): ensure that lines that start at index zero kill the indentation

Previously we were trying to be clever and guess that lines that had zero indentation were actually
just rolling over from the previous line and so were ignored.

But since we ignore the first line if it has no indentation, we had to rely on the second line having
no indentation for the zero indentation to be set. If the second line had indentation then all future
zero indentation lines were being ignored.

This change now never ignores zero indent lines and so will indent most things properly. If a line is
rolling over then it should be indented to the minimum level already for it to be displayed correctly.

See angular/angular.js#10101

Author: petebacondarwin

base/services/trimIndentation.js

@@ -6,23 +6,25 @@ function calcIndent(text) {
   var MAX_INDENT = 9999;
   var lines = text.split('\n');
   var minIndent = MAX_INDENT;
+  var emptyLinesRemoved = false;
+
+  // ignore leading empty lines
+  while(isEmpty(lines[0])) {
+    lines.shift();
+    emptyLinesRemoved = true;
+  }
 
   // ignore first line if it has no indentation and there is more than one line
   // this is because sometimes our text starts in the middle of a line of other
   // text that is indented and so doesn't appear to have an indent when it really does.
   var ignoreLine = (lines[0][0] != ' '  && lines.length > 1);
-  if ( ignoreLine ) {
-    lines.shift();
-  }
-  // ignore leading empty lines
-  while(isEmpty(lines[0])) {
+  if ( ignoreLine && !emptyLinesRemoved ) {
     lines.shift();
   }
 
   lines.forEach(function(line){
-    var indent = line.match(/^\s*/)[0].length;
-    // If indent is 0 then we assume that it is just an overflow and not part of the indentation
-    if (indent > 0 || minIndent == MAX_INDENT) {
+    if ( !isEmpty(line) ) {
+      var indent = line.match(/^\s*/)[0].length;
       minIndent = Math.min(minIndent, indent);
     }
   });

base/services/trimIndentation.spec.js

@@ -24,6 +24,24 @@ describe("trimIndentation", function() {
     expect(trimIndentation('abc\n\n\n')).toEqual('abc');
   });
 
+  it("should not trim indentation if more than the first line is not indented", function() {
+    expect(trimIndentation(
+      '.ng-hide {\n' +
+      '  /* this is just another form of hiding an element */\n' +
+      '  display:block!important;\n' +
+      '  position:absolute;\n' +
+      '  top:-9999px;\n' +
+      '  left:-9999px;\n' +
+      '}')).toEqual(
+      '.ng-hide {\n' +
+      '  /* this is just another form of hiding an element */\n' +
+      '  display:block!important;\n' +
+      '  position:absolute;\n' +
+      '  top:-9999px;\n' +
+      '  left:-9999px;\n' +
+      '}');
+  });
+
   describe("calcIndent", function() {
     it("should calculate simple leading white-space from a single line of text", function() {
       expect(trimIndentation.calcIndent('   abc  ')).toEqual(3);