Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

docs(router): chalin router copyedits #3054 #3060

Merged

Conversation

wardbell
Copy link
Contributor

@wardbell wardbell commented Jan 1, 2017

Plus Ward's additional copy edits to the copy edits.

See original PR #3054

Also added advice on router module order and a way to find out what the router's runtime configuration actually is.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

1 similar comment
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@wardbell wardbell mentioned this pull request Jan 1, 2017
@wardbell wardbell changed the title docs(router): chalin router copyedits #1226 docs(router): chalin router copyedits #3054 Jan 1, 2017
@wardbell wardbell merged commit ce174a2 into angular:master Jan 1, 2017
@wardbell wardbell deleted the chalin-chalin-router-copyedits-1226 branch January 1, 2017 08:25
abdel-ships-it pushed a commit to abdel-ships-it/angular.io that referenced this pull request Feb 11, 2017
* docs(router): chalin copyedits
* docs(router): bell copy edits + routing module order & inspect config
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants