Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

docs(router): copyedits #3054

Closed
wants to merge 1 commit into from

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Dec 30, 2016

Continuation of #3025.

cc @wardbell @kwalrath

@wardbell
Copy link
Contributor

wardbell commented Jan 1, 2017

This is great. But I need to copy edit a few of the copy edits and this branch isn't in the IdeaBlade repo (ahem!).

Therefore, I had to close and move it to a new PR #3060

It renders in the the DOM as a `<router-outlet>` element.
The router inserts the outlet's view components as sibling elements,
immediately _after_ the closing `</router-outlet>` tag.
The `<router-outlet>` element is rendered in the DOM.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed more thorough rewrite

@@ -567,24 +570,24 @@ a#default-route
:marked
### The _default_ route to heroes

When the application launches, the initial URL in the browser bar is something like:
When the application launches, an initial URL in the browser bar is something like:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disagree: "the" was correct. There can be only one "initial" url


a#redirect
:marked
### Redirecting routes

The preferred solution is to add a `redirect` route that translates from the initial relative URL (`''`)
to the desired default path (`/heroes`). The browser address bar shows `~/heroes` as if you'd navigated there directly.
The preferred solution is to add a `redirect` route that translates an initial relative URL (`''`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverting to "the"; see comment above.

The first step is to **create a separate `app/heroes/` folder**
and add *Hero Management* feature files there.
This example has capabilities very similar to the
[Tour of Heroes tutorial, Part 5](../tutorial/toh-pt5.html),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, per issue #3055, we should have been referring to the "Services" episode. Fixing that in my update.

The new *Crisis Center* begins as a virtual copy of the *Heroes* module.
Create a new `app/crisis-center` folder, copy the Hero files,
and change every mention of "hero" to "crisis".
It's time to add real features to the app's current placeholder crisis center.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree this passage needed work. I took it a bit further.

:marked
While building out the *Crisis Center* feature, you navigated to the
*Crisis Detail* route using a so-called **absolute path** that begins with a _slash_.
### Relative navigation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always add an explicit anchor in case the section title changes; don't want to break external links.

@wardbell wardbell closed this Jan 1, 2017
wardbell added a commit that referenced this pull request Jan 1, 2017
* docs(router): chalin copyedits
* docs(router): bell copy edits + routing module order & inspect config
@chalin
Copy link
Contributor Author

chalin commented Jan 18, 2017

Thanks Ward. Sorry, that I forgot to commit to the IdeaBlade repo (I hit the publish button in the GH app out of habit, as I usually do for my Dart work). I'll commit to IB repo once again moving forward.

@chalin chalin deleted the chalin-router-copyedits-1226 branch January 27, 2017 15:50
abdel-ships-it pushed a commit to abdel-ships-it/angular.io that referenced this pull request Feb 11, 2017
* docs(router): chalin copyedits
* docs(router): bell copy edits + routing module order & inspect config
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants