Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

example(template-syntax): follow style-guide and other updates #2750

Merged
merged 4 commits into from
Nov 11, 2016
Merged

example(template-syntax): follow style-guide and other updates #2750

merged 4 commits into from
Nov 11, 2016

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Nov 4, 2016

  • Follow style guide: rename sizer.component.ts to my-sizer.component.ts (given the selector my-sizer); also appropriately rename class.
  • Rename AppComponent.fontSize to AppComponent.fontSizePx because it is assigned to [style.font-size.px] and so represents a size in px, not a general font-size value (which could be, e.g., “x-large”).
  • Added small interactive example of NgStyle.

@chalin chalin mentioned this pull request Nov 4, 2016
Merged
@chalin chalin force-pushed the chalin-ts-template-syntax-1104 branch from f447315 to 2d6571d Compare November 8, 2016 16:30
@chalin chalin mentioned this pull request Nov 8, 2016
Closed
3 tasks
wardbell
wardbell suggested changes Nov 10, 2016
View reviewed changes
Copy link
Contributor

@wardbell wardbell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this PR except for the components/directives named My....

I don't want to add another. Rather, I want "My" dropped from all names for the important reason that we should NOT encourage people to match component names to selector names.

Actually, thanks for pointing this out, even if the path I'm now urging contradicts the path I took when I first wrote this page ;-)

public/docs/_examples/template-syntax/e2e-spec.ts
let incButton = div.element(by.buttonText('+'));
let input = div.element(by.css('input'));
let initSize = await input.getAttribute('value');
incButton.click();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that we don't have to wait for the browser to settle after clicking the button. That line had a purpose at one time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, e2e tests run fine:

Suites passed:
  public/docs/_examples/template-syntax/ts
All tests passed

public/docs/_examples/template-syntax/ts/app/app.component.html
@@ -351,21 +351,22 @@
<hr><h2 id="two-way">Two-way Binding</h2>
<div id="two-way-1">
<!-- #docregion two-way-1 -->
<my-sizer [(size)]="fontSize"></my-sizer>
<div [style.font-size.px]="fontSize">Resizable Text</div>
<my-sizer [(size)]="fontSizePx"></my-sizer>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems picayune. I feel it distracts from the point and starts a conversation that isn't helpful. I can understand that you feel that being inspecific about the units in the property name provokes a distracting conversation too. I don't actually feel strongly about this so I'd say "whatever, OK" .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this is mainly to avoid a conflict with a string property named fontSize whose initial value is "large".

It seemed to me that since the property is being assigned to [style.font-size.px] (see the old line 355 above) it could naturally be named fontSizePx (which is the camel-case equivalent of the style attribute it is being assigned to).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm cool with it

public/docs/ts/latest/guide/template-syntax.jade
@@ -490,8 +490,8 @@ table
If we must read a target element property or call one of its methods,
we'll need a different technique.
See the API reference for
[viewChild](../api/core/index/ViewChild-decorator.html) and
[contentChild](../api/core/index/ContentChild-decorator.html).
[ViewChild](../api/core/index/ViewChild-decorator.html) and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

public/docs/ts/latest/guide/template-syntax.jade
@@ -778,7 +775,7 @@ block style-property-name-dart-diff

<a id="eventemitter"></a>
<a id="custom-event"></a>
### Custom Events with EventEmitter
### Custom events with EventEmitter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make "EventEmitter" italic. That's the (desired) standard presentation of code elements in a header ... because EventEmitter doesn't display well in a header.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

public/docs/ts/latest/guide/template-syntax.jade
:marked
The `[(x)]` syntax is easy to demonstrate when the element has a settable property called `x`
and a corresponding event named `xChange`.
Here's a `SizerComponent` that fits the pattern.
Here's a `MySizerComponent` that fits the pattern.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my corrective above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted.

@chalin
example(template-syntax): follow style-guide and other updates
602b2ff 
- Follow style guide: rename `sizer.component.ts` to
`my-sizer.component.ts` (given the selector `my-sizer`); also
appropriately rename class.
- Rename `AppComponent.fontSize` to `AppComponent.fontSizePx` because
it is assigned to `[style.font-size.px]` and so represents a size in
px, not a general font-size value (which could be, e.g., “x-large”).
- Added small interactive example of `NgStyle`.
@chalin
Kathy's post-review edits
b801b45 
cc @kwalrath
@chalin
Kathy's post-review edits 2
a934ede
@chalin chalin force-pushed the chalin-ts-template-syntax-1104 branch 2 times, most recently from cdcd79e to 917c51d Compare November 10, 2016 23:10
@chalin
Copy link
Contributor Author

chalin commented Nov 10, 2016

@wardbell - addressed your concerns with the last commit:

  • Keep my- and my prefixes on selectors (for components and
    directives respectively).
  • Drop my- from file names.
  • Drop My as component class prefix.

@chalin
Ward's post-review updates
da08ad1 
- Keep `my-` and `my` prefixes on selectors (for components and
directives respectively).
- Drop `my-` from file names.
- Drop `My` as component class prefix.
@chalin chalin force-pushed the chalin-ts-template-syntax-1104 branch from 917c51d to da08ad1 Compare November 10, 2016 23:35
@wardbell wardbell merged commit 64a8754 into angular:master Nov 11, 2016
@wardbell wardbell deleted the chalin-ts-template-syntax-1104 branch November 11, 2016 04:01
filipesilva added a commit to IdeaBlade/angular.io that referenced this pull request Nov 15, 2016
@filipesilva
Squashed commit of the following:
eb60bfe 
commit 17c7e15
Author: Filipe Silva <[email protected]>
Date:   Mon Nov 14 23:11:37 2016 +0000

    chore: update to 2.2.0 (angular#2797)

commit 1e5facf
Merge: 5c4cc9a db0fac9
Author: Ward Bell <[email protected]>
Date:   Mon Nov 14 12:44:51 2016 -0800

    Merge pull request angular#2799 from IdeaBlade/docs-changelog-2.2.0

    chore(changelog): update docs changelog for Ng v.2.2.0

commit 5c4cc9a
Merge: 43457e9 1afe5dc
Author: Ward Bell <[email protected]>
Date:   Mon Nov 14 12:43:09 2016 -0800

    docs(router): Updated usage of observables in router tutorial and developer guide (angular#2696)

    Moved route configuration into separate variable for consistency
    Added async pipe to handle subscriptions for list items

commit 43457e9
Merge: a423a5a 2649647
Author: Jesús Rodríguez <[email protected]>
Date:   Mon Nov 14 21:38:49 2016 +0100

    chore: add upgrade/static to API reference (angular#2755)

commit 1afe5dc
Author: Brandon Roberts <[email protected]>
Date:   Sat Oct 29 16:08:54 2016 -0500

    docs(router): Updated usage of observables in router tutorial and developer guide

    Moved route configuration into separate variable for consistency
    Added async pipe to handle subscriptions for list items

commit db0fac9
Author: Ward Bell <[email protected]>
Date:   Mon Nov 14 10:48:09 2016 -0800

    chore(changelog): update docs changelog for Ng v.2.2.0

commit a423a5a
Author: ikilled <[email protected]>
Date:   Mon Nov 14 18:39:46 2016 +0000

    clicking on Books & Training sends user to Education (angular#2701)

    When user clicks in Books & Training item in footer the website should take them to Education section (anchor) in the middle of the page, not to the top where Development section is.

commit d63b1cc
Merge: f627706 8508140
Author: Ward Bell <[email protected]>
Date:   Mon Nov 14 10:35:48 2016 -0800

    docs(router): fixed verbiage about router-outlet (angular#2746)

commit f627706
Author: Ward Bell <[email protected]>
Date:   Mon Nov 14 10:26:13 2016 -0800

    docs(cookbook-aot-compiler): improve Ahead-of-Time compilation cookbook (angular#2798)

    closes angular#2790

commit 75464d5
Merge: 78e2584 02f5559
Author: Ward Bell <[email protected]>
Date:   Mon Nov 14 09:34:36 2016 -0800

    Merge pull request angular#2794 from IdeaBlade/chalin-guide-misc-fix-1113

    docs: guide/index misc Jade fixes

commit 78e2584
Merge: 182493f 85062c4
Author: Ward Bell <[email protected]>
Date:   Mon Nov 14 09:33:55 2016 -0800

    Merge pull request angular#2795 from IdeaBlade/chalin-util-js-getExampleName-1114

    chore(util.js): getExampleName - support optional .html suffix

commit 182493f
Merge: 9e9666b 53f5538
Author: Ward Bell <[email protected]>
Date:   Mon Nov 14 09:28:40 2016 -0800

    feat(cb-ts-to-js): add es6 examples (angular#2606)

    * feat(cb-ts-to-js): add es6 examples
    update docshredder to shred .es6
    optimized focus gulp task
    convert imports and metadate sections
    add DI section
    add host and query metadata section
    add intro
    fix capitalization and grammar

    * docs(ts-to-js): ward's edits (incomplete)

    * docs(ts-to-js): add separate template files for some components

    * docs(cb-ts-to-js): refactor sample code

commit 53f5538
Author: Ward Bell <[email protected]>
Date:   Sun Nov 13 14:09:28 2016 -0800

    docs(cb-ts-to-js): refactor sample code

commit 9e9666b
Author: Patrice Chalin <[email protected]>
Date:   Mon Nov 14 08:34:10 2016 -0800

    docs(template-syntax/dart): updates to match TS (angular#2751)

    * docs(template-syntax): refresh _cache

    * docs(template-syntax/dart): updates to match TS

    - Propagates TS-side changes:
      - update angular#2639 - new two-way binding section, and
      - fix angular#2687 - invalid attr syntax
    - Fixes
      - angular#1898 - currency symbols
      - angular#2748 - Dart template-syntax e2e is failing
      - angular#2749 - deprecated `[className]`

    * updated _cache file following Kathy's post-review edits

    * Post Ward's review w/ cache updated

    - Keep `my-` and `my` prefixes on selectors (for components and
    directives, respectively).
    - Drop `my-` from file names.
    - Drop `My` as component class prefix.

commit 5dcffd6
Author: Patrice Chalin <[email protected]>
Date:   Sun Nov 13 19:37:13 2016 -0800

    docs: dart glossary - fix misnamed Jade block

commit 6680acc
Merge: 14db838 3b03573
Author: Kathy Walrath <[email protected]>
Date:   Mon Nov 14 08:31:11 2016 -0800

    docs(toh): avoid dup header title (angular#2796)

    * remove redundant headings

    * update _cache

    * misc: make block comment a Jade comment

    (This prevents the text from appearing in the generated HTML as an HTML
    comment.)

commit 3b03573
Author: Patrice Chalin <[email protected]>
Date:   Mon Nov 14 05:30:05 2016 -0800

    misc: make block comment a Jade comment

    (This prevents the text from appearing in the generated HTML as an HTML
    comment.)

commit 470426d
Author: Patrice Chalin <[email protected]>
Date:   Mon Nov 14 05:25:36 2016 -0800

    update _cache

commit c12d75a
Author: Patrice Chalin <[email protected]>
Date:   Mon Nov 14 05:23:35 2016 -0800

    remove redundant headings

commit 85062c4
Author: Patrice Chalin <[email protected]>
Date:   Mon Nov 14 04:56:12 2016 -0800

    chore(util.js): getExampleName - support optional .html suffix

commit 02f5559
Author: Patrice Chalin <[email protected]>
Date:   Mon Nov 14 04:29:17 2016 -0800

    docs: guide/index misc Jade fixes

    - Eliminate use of deprecated `clear=“all”` in `<br>`.
    - No need for local `langName`; use global `_Lang` var instead.
    - Remove duplicate id `learning-path`.

commit 14db838
Author: Naomi Black <[email protected]>
Date:   Sun Nov 13 21:48:52 2016 -0500

    news(nov): Some news and a blog post update

commit eff32ec
Author: Naomi Black <[email protected]>
Date:   Sun Nov 13 21:48:37 2016 -0500

    chore(bios): update some bios for leads

commit 3ee36fb
Author: koyner <[email protected]>
Date:   Sun Nov 13 22:59:59 2016 +0100

    docs(forms): grammar fix (angular#2764)

commit b11438f
Author: Ward Bell <[email protected]>
Date:   Fri Nov 11 19:44:00 2016 -0800

    docs(ts-to-js): add separate template files for some components

commit 33b6197
Author: Ward Bell <[email protected]>
Date:   Thu Nov 3 01:37:55 2016 -0700

    docs(ts-to-js): ward's edits (incomplete)

commit 12eb19f
Author: Filipe Silva <[email protected]>
Date:   Thu Oct 13 17:59:00 2016 +0100

    feat(cb-ts-to-js): add es6 examples
    update docshredder to shred .es6
    optimized focus gulp task
    convert imports and metadate sections
    add DI section
    add host and query metadata section
    add intro
    fix capitalization and grammar

commit 64a8754
Author: Patrice Chalin <[email protected]>
Date:   Thu Nov 10 20:01:36 2016 -0800

    example(template-syntax): follow style-guide and other updates (angular#2750)

commit 7619cdf
Author: Jesús Rodríguez <[email protected]>
Date:   Thu Nov 10 23:47:30 2016 +0100

    chore: ability to open a plunker on a specific file (angular#2778)

commit 0161d9d
Author: Filipe Silva <[email protected]>
Date:   Thu Nov 10 22:45:22 2016 +0000

    chore: ignore debug.log file (angular#2785)

    This file is generated when running `gulp e2e` and often enough committed by mistake.

    /cc @Foxandxss

commit f92983c
Author: Jesús Rodríguez <[email protected]>
Date:   Thu Nov 10 23:44:51 2016 +0100

    docs(ngmodule): fix plunkers (angular#2786)

commit 03db4bb
Author: Martin Eckardt <[email protected]>
Date:   Wed Nov 9 17:43:40 2016 +0100

    docs(a1-a2): fix link to Filter/Pipes (angular#2770)

commit 60565a5
Author: Pavol Pitonak <[email protected]>
Date:   Wed Nov 9 17:42:57 2016 +0100

    docs(testing): configureTestModule -> configureTestingModule (angular#2767)

commit ec47197
Author: Catalin Zalog <[email protected]>
Date:   Wed Nov 9 18:41:56 2016 +0200

    docs(style-guide): fix missing *.ts (angular#2763)

commit 234e468
Author: Patrice Chalin <[email protected]>
Date:   Tue Nov 8 08:21:02 2016 -0800

    docs: intra-site links should be relative

    Contributes to angular#2772.

commit 6b37da7
Author: Patrice Chalin <[email protected]>
Date:   Tue Nov 8 09:27:10 2016 -0800

    docs(forms/dart): remove mention of FORM_DIRECTIVES

    Fixes angular#2752

commit c24dd07
Author: Patrice Chalin <[email protected]>
Date:   Tue Nov 8 14:48:03 2016 -0800

    docs(toh-5/dart): use routerLink in dashboard (angular#2744)

    * docs(toh-5/dart): use routerLink in dashboard

    * minor edits to TS jade

    * remove dart/toh-pt5 from bad-code-excerpt-skip-patterns

commit 2808878
Author: Patrice Chalin <[email protected]>
Date:   Tue Nov 8 07:41:27 2016 -0800

    chore(deploy): don't name project in firebase deploy

    Naming the project would sometimes cause gulp to report `An unexpected
    error has occurred` with exit code 2.

commit 2649647
Author: Jesus Rodriguez <[email protected]>
Date:   Sat Nov 5 00:37:47 2016 +0100

    chore: add upgrade/static to API reference

commit 8508140
Merge: 37f93bc b1c2c27
Author: Adrian Irwin <[email protected]>
Date:   Thu Nov 3 17:27:43 2016 -0700

    Merge branch 'router' of https://github.com/adrianirwin/angular.io into router

commit 37f93bc
Author: Adrian Irwin <[email protected]>
Date:   Thu Nov 3 17:25:55 2016 -0700

    docs(router): fixed verbiage and example of how routed views are related to the router outlet

commit b1c2c27
Author: Adrian Irwin <[email protected]>
Date:   Thu Nov 3 16:57:56 2016 -0700

    docs(router): fixed verbiage and example of how routed views are related to the router outlet
filipesilva added a commit that referenced this pull request Nov 15, 2016
@filipesilva
docs(upgrade): Use NgUpgrade static (#2781)
52f6693 
* re-enable upgrade-adapter and upgrade-phonecat-1 tests

* re-enable upgrade-phonecat-2 tests

* add hybrid toggle switch to helpers

* use 2.2.0-rc.0

* revert change to browser.ignoreSynchronization

* convert 1-2-hybrid-bootstrap to upgrade/static

* remove shared adapter example

* add systemjs config extras to all indexes

* update upgrade-static

* update upgrade-io example

* update downgrade-static

* update downgrade-io

* update 1-to-2-projection

* update 2-to-1-transclusion

* update 1-to-2-providers

* update 2-to-1-providers

* cleanup upgrade-adapter e2e test

* re-enable upgrade-adapter tests

* change HeroDetailComponent to HeroDetailDirective

* fix missing systemjs.config.extras

* add typing to UpgradeModule DI

* update upgrade-phonecat-2-hybrid

* update upgrade-adapter's prose

* rename upgrade-adapter example to upgrade-module

* improve angular1 type declaration in hybrid apps

* remove unused imports in protractor-helpers

* update phonecat-hybrid bootstrap prose

* update phonecat-hybrid service and components

* update phonecat-final prose

* update e2e prose

* update systemjs.config.js to have @angular/upgrade/static by default

* add aot (WIP)

* remove wip aot changes from test run

* change let to const in bootstrap

* elaborate upgraded component alert

* use 2.2.0 versions instead of rc0

* Squashed commit of the following:

commit 17c7e15
Author: Filipe Silva <[email protected]>
Date:   Mon Nov 14 23:11:37 2016 +0000

    chore: update to 2.2.0 (#2797)

commit 1e5facf
Merge: 5c4cc9a db0fac9
Author: Ward Bell <[email protected]>
Date:   Mon Nov 14 12:44:51 2016 -0800

    Merge pull request #2799 from IdeaBlade/docs-changelog-2.2.0

    chore(changelog): update docs changelog for Ng v.2.2.0

commit 5c4cc9a
Merge: 43457e9 1afe5dc
Author: Ward Bell <[email protected]>
Date:   Mon Nov 14 12:43:09 2016 -0800

    docs(router): Updated usage of observables in router tutorial and developer guide (#2696)

    Moved route configuration into separate variable for consistency
    Added async pipe to handle subscriptions for list items

commit 43457e9
Merge: a423a5a 2649647
Author: Jesús Rodríguez <[email protected]>
Date:   Mon Nov 14 21:38:49 2016 +0100

    chore: add upgrade/static to API reference (#2755)

commit 1afe5dc
Author: Brandon Roberts <[email protected]>
Date:   Sat Oct 29 16:08:54 2016 -0500

    docs(router): Updated usage of observables in router tutorial and developer guide

    Moved route configuration into separate variable for consistency
    Added async pipe to handle subscriptions for list items

commit db0fac9
Author: Ward Bell <[email protected]>
Date:   Mon Nov 14 10:48:09 2016 -0800

    chore(changelog): update docs changelog for Ng v.2.2.0

commit a423a5a
Author: ikilled <[email protected]>
Date:   Mon Nov 14 18:39:46 2016 +0000

    clicking on Books & Training sends user to Education (#2701)

    When user clicks in Books & Training item in footer the website should take them to Education section (anchor) in the middle of the page, not to the top where Development section is.

commit d63b1cc
Merge: f627706 8508140
Author: Ward Bell <[email protected]>
Date:   Mon Nov 14 10:35:48 2016 -0800

    docs(router): fixed verbiage about router-outlet (#2746)

commit f627706
Author: Ward Bell <[email protected]>
Date:   Mon Nov 14 10:26:13 2016 -0800

    docs(cookbook-aot-compiler): improve Ahead-of-Time compilation cookbook (#2798)

    closes #2790

commit 75464d5
Merge: 78e2584 02f5559
Author: Ward Bell <[email protected]>
Date:   Mon Nov 14 09:34:36 2016 -0800

    Merge pull request #2794 from IdeaBlade/chalin-guide-misc-fix-1113

    docs: guide/index misc Jade fixes

commit 78e2584
Merge: 182493f 85062c4
Author: Ward Bell <[email protected]>
Date:   Mon Nov 14 09:33:55 2016 -0800

    Merge pull request #2795 from IdeaBlade/chalin-util-js-getExampleName-1114

    chore(util.js): getExampleName - support optional .html suffix

commit 182493f
Merge: 9e9666b 53f5538
Author: Ward Bell <[email protected]>
Date:   Mon Nov 14 09:28:40 2016 -0800

    feat(cb-ts-to-js): add es6 examples (#2606)

    * feat(cb-ts-to-js): add es6 examples
    update docshredder to shred .es6
    optimized focus gulp task
    convert imports and metadate sections
    add DI section
    add host and query metadata section
    add intro
    fix capitalization and grammar

    * docs(ts-to-js): ward's edits (incomplete)

    * docs(ts-to-js): add separate template files for some components

    * docs(cb-ts-to-js): refactor sample code

commit 53f5538
Author: Ward Bell <[email protected]>
Date:   Sun Nov 13 14:09:28 2016 -0800

    docs(cb-ts-to-js): refactor sample code

commit 9e9666b
Author: Patrice Chalin <[email protected]>
Date:   Mon Nov 14 08:34:10 2016 -0800

    docs(template-syntax/dart): updates to match TS (#2751)

    * docs(template-syntax): refresh _cache

    * docs(template-syntax/dart): updates to match TS

    - Propagates TS-side changes:
      - update #2639 - new two-way binding section, and
      - fix #2687 - invalid attr syntax
    - Fixes
      - #1898 - currency symbols
      - #2748 - Dart template-syntax e2e is failing
      - #2749 - deprecated `[className]`

    * updated _cache file following Kathy's post-review edits

    * Post Ward's review w/ cache updated

    - Keep `my-` and `my` prefixes on selectors (for components and
    directives, respectively).
    - Drop `my-` from file names.
    - Drop `My` as component class prefix.

commit 5dcffd6
Author: Patrice Chalin <[email protected]>
Date:   Sun Nov 13 19:37:13 2016 -0800

    docs: dart glossary - fix misnamed Jade block

commit 6680acc
Merge: 14db838 3b03573
Author: Kathy Walrath <[email protected]>
Date:   Mon Nov 14 08:31:11 2016 -0800

    docs(toh): avoid dup header title (#2796)

    * remove redundant headings

    * update _cache

    * misc: make block comment a Jade comment

    (This prevents the text from appearing in the generated HTML as an HTML
    comment.)

commit 3b03573
Author: Patrice Chalin <[email protected]>
Date:   Mon Nov 14 05:30:05 2016 -0800

    misc: make block comment a Jade comment

    (This prevents the text from appearing in the generated HTML as an HTML
    comment.)

commit 470426d
Author: Patrice Chalin <[email protected]>
Date:   Mon Nov 14 05:25:36 2016 -0800

    update _cache

commit c12d75a
Author: Patrice Chalin <[email protected]>
Date:   Mon Nov 14 05:23:35 2016 -0800

    remove redundant headings

commit 85062c4
Author: Patrice Chalin <[email protected]>
Date:   Mon Nov 14 04:56:12 2016 -0800

    chore(util.js): getExampleName - support optional .html suffix

commit 02f5559
Author: Patrice Chalin <[email protected]>
Date:   Mon Nov 14 04:29:17 2016 -0800

    docs: guide/index misc Jade fixes

    - Eliminate use of deprecated `clear=“all”` in `<br>`.
    - No need for local `langName`; use global `_Lang` var instead.
    - Remove duplicate id `learning-path`.

commit 14db838
Author: Naomi Black <[email protected]>
Date:   Sun Nov 13 21:48:52 2016 -0500

    news(nov): Some news and a blog post update

commit eff32ec
Author: Naomi Black <[email protected]>
Date:   Sun Nov 13 21:48:37 2016 -0500

    chore(bios): update some bios for leads

commit 3ee36fb
Author: koyner <[email protected]>
Date:   Sun Nov 13 22:59:59 2016 +0100

    docs(forms): grammar fix (#2764)

commit b11438f
Author: Ward Bell <[email protected]>
Date:   Fri Nov 11 19:44:00 2016 -0800

    docs(ts-to-js): add separate template files for some components

commit 33b6197
Author: Ward Bell <[email protected]>
Date:   Thu Nov 3 01:37:55 2016 -0700

    docs(ts-to-js): ward's edits (incomplete)

commit 12eb19f
Author: Filipe Silva <[email protected]>
Date:   Thu Oct 13 17:59:00 2016 +0100

    feat(cb-ts-to-js): add es6 examples
    update docshredder to shred .es6
    optimized focus gulp task
    convert imports and metadate sections
    add DI section
    add host and query metadata section
    add intro
    fix capitalization and grammar

commit 64a8754
Author: Patrice Chalin <[email protected]>
Date:   Thu Nov 10 20:01:36 2016 -0800

    example(template-syntax): follow style-guide and other updates (#2750)

commit 7619cdf
Author: Jesús Rodríguez <[email protected]>
Date:   Thu Nov 10 23:47:30 2016 +0100

    chore: ability to open a plunker on a specific file (#2778)

commit 0161d9d
Author: Filipe Silva <[email protected]>
Date:   Thu Nov 10 22:45:22 2016 +0000

    chore: ignore debug.log file (#2785)

    This file is generated when running `gulp e2e` and often enough committed by mistake.

    /cc @Foxandxss

commit f92983c
Author: Jesús Rodríguez <[email protected]>
Date:   Thu Nov 10 23:44:51 2016 +0100

    docs(ngmodule): fix plunkers (#2786)

commit 03db4bb
Author: Martin Eckardt <[email protected]>
Date:   Wed Nov 9 17:43:40 2016 +0100

    docs(a1-a2): fix link to Filter/Pipes (#2770)

commit 60565a5
Author: Pavol Pitonak <[email protected]>
Date:   Wed Nov 9 17:42:57 2016 +0100

    docs(testing): configureTestModule -> configureTestingModule (#2767)

commit ec47197
Author: Catalin Zalog <[email protected]>
Date:   Wed Nov 9 18:41:56 2016 +0200

    docs(style-guide): fix missing *.ts (#2763)

commit 234e468
Author: Patrice Chalin <[email protected]>
Date:   Tue Nov 8 08:21:02 2016 -0800

    docs: intra-site links should be relative

    Contributes to #2772.

commit 6b37da7
Author: Patrice Chalin <[email protected]>
Date:   Tue Nov 8 09:27:10 2016 -0800

    docs(forms/dart): remove mention of FORM_DIRECTIVES

    Fixes #2752

commit c24dd07
Author: Patrice Chalin <[email protected]>
Date:   Tue Nov 8 14:48:03 2016 -0800

    docs(toh-5/dart): use routerLink in dashboard (#2744)

    * docs(toh-5/dart): use routerLink in dashboard

    * minor edits to TS jade

    * remove dart/toh-pt5 from bad-code-excerpt-skip-patterns

commit 2808878
Author: Patrice Chalin <[email protected]>
Date:   Tue Nov 8 07:41:27 2016 -0800

    chore(deploy): don't name project in firebase deploy

    Naming the project would sometimes cause gulp to report `An unexpected
    error has occurred` with exit code 2.

commit 2649647
Author: Jesus Rodriguez <[email protected]>
Date:   Sat Nov 5 00:37:47 2016 +0100

    chore: add upgrade/static to API reference

commit 8508140
Merge: 37f93bc b1c2c27
Author: Adrian Irwin <[email protected]>
Date:   Thu Nov 3 17:27:43 2016 -0700

    Merge branch 'router' of https://github.com/adrianirwin/angular.io into router

commit 37f93bc
Author: Adrian Irwin <[email protected]>
Date:   Thu Nov 3 17:25:55 2016 -0700

    docs(router): fixed verbiage and example of how routed views are related to the router outlet

commit b1c2c27
Author: Adrian Irwin <[email protected]>
Date:   Thu Nov 3 16:57:56 2016 -0700

    docs(router): fixed verbiage and example of how routed views are related to the router outlet

* deactivate bugged tests
chalin added a commit to chalin/site-webdev that referenced this pull request Jan 21, 2017
@chalin
[ng] template-syntax example component rename
c56545f 
This PR is a propagation of a final round of changes made to the TS
example; see
angular/angular.io#2750 (comment)

E2E tests are still passing.

Fixes #286
chalin added a commit to chalin/site-webdev that referenced this pull request Jan 21, 2017
@chalin
[ng] template-syntax example component rename
47c8e3e 
This PR is a propagation of a final round of changes made to the TS
example; see
angular/angular.io#2750 (comment)

E2E tests are still passing.

Fixes #286
chalin added a commit to chalin/site-webdev that referenced this pull request Jan 21, 2017
@chalin
[ng] template-syntax example component rename
5c75b25 
This PR is a propagation of a final round of changes made to the TS
example; see
angular/angular.io#2750 (comment)

E2E tests are still passing.

Fixes #286
filiph pushed a commit to filiph/site-webdev that referenced this pull request Feb 10, 2017
@chalin @filiph
[ng] template-syntax example component rename (#326)
08190dc 
This PR is a propagation of a final round of changes made to the TS
example; see
angular/angular.io#2750 (comment)

E2E tests are still passing.

Fixes #286
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wardbell wardbell wardbell approved these changes

Assignees
No one assigned
Labels
CLA: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chalin @wardbell @googlebot