This repository was archived by the owner on Dec 4, 2017. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 877
docs(toh-5/dart): use routerLink in dashboard #2744
Merged
kwalrath
merged 3 commits into
angular:master
from
IdeaBlade:chalin-dart-toh-routerLink-updates-1103
Nov 8, 2016
Merged
docs(toh-5/dart): use routerLink in dashboard #2744
kwalrath
merged 3 commits into
angular:master
from
IdeaBlade:chalin-dart-toh-routerLink-updates-1103
Nov 8, 2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a677d19
to
c32800b
Compare
As agreed with @kwalrath, here is the updated prose and code, with a mention of angulardart/angular#186. |
@wardbell @filipesilva @Foxandxss - minor updates were made to the TS .jade file, see changes here, ignoring whitespace. |
@chalin looks fine to me for the TS changes. The removal of the docregion terminator in |
kwalrath
approved these changes
Nov 8, 2016
@filipesilva - right, doc regions are automatically closed at the end of file; so explicitly naming them is unnecessary. Thanks for the review! |
filipesilva
added a commit
to IdeaBlade/angular.io
that referenced
this pull request
Nov 15, 2016
commit 17c7e15 Author: Filipe Silva <[email protected]> Date: Mon Nov 14 23:11:37 2016 +0000 chore: update to 2.2.0 (angular#2797) commit 1e5facf Merge: 5c4cc9a db0fac9 Author: Ward Bell <[email protected]> Date: Mon Nov 14 12:44:51 2016 -0800 Merge pull request angular#2799 from IdeaBlade/docs-changelog-2.2.0 chore(changelog): update docs changelog for Ng v.2.2.0 commit 5c4cc9a Merge: 43457e9 1afe5dc Author: Ward Bell <[email protected]> Date: Mon Nov 14 12:43:09 2016 -0800 docs(router): Updated usage of observables in router tutorial and developer guide (angular#2696) Moved route configuration into separate variable for consistency Added async pipe to handle subscriptions for list items commit 43457e9 Merge: a423a5a 2649647 Author: Jesús Rodríguez <[email protected]> Date: Mon Nov 14 21:38:49 2016 +0100 chore: add upgrade/static to API reference (angular#2755) commit 1afe5dc Author: Brandon Roberts <[email protected]> Date: Sat Oct 29 16:08:54 2016 -0500 docs(router): Updated usage of observables in router tutorial and developer guide Moved route configuration into separate variable for consistency Added async pipe to handle subscriptions for list items commit db0fac9 Author: Ward Bell <[email protected]> Date: Mon Nov 14 10:48:09 2016 -0800 chore(changelog): update docs changelog for Ng v.2.2.0 commit a423a5a Author: ikilled <[email protected]> Date: Mon Nov 14 18:39:46 2016 +0000 clicking on Books & Training sends user to Education (angular#2701) When user clicks in Books & Training item in footer the website should take them to Education section (anchor) in the middle of the page, not to the top where Development section is. commit d63b1cc Merge: f627706 8508140 Author: Ward Bell <[email protected]> Date: Mon Nov 14 10:35:48 2016 -0800 docs(router): fixed verbiage about router-outlet (angular#2746) commit f627706 Author: Ward Bell <[email protected]> Date: Mon Nov 14 10:26:13 2016 -0800 docs(cookbook-aot-compiler): improve Ahead-of-Time compilation cookbook (angular#2798) closes angular#2790 commit 75464d5 Merge: 78e2584 02f5559 Author: Ward Bell <[email protected]> Date: Mon Nov 14 09:34:36 2016 -0800 Merge pull request angular#2794 from IdeaBlade/chalin-guide-misc-fix-1113 docs: guide/index misc Jade fixes commit 78e2584 Merge: 182493f 85062c4 Author: Ward Bell <[email protected]> Date: Mon Nov 14 09:33:55 2016 -0800 Merge pull request angular#2795 from IdeaBlade/chalin-util-js-getExampleName-1114 chore(util.js): getExampleName - support optional .html suffix commit 182493f Merge: 9e9666b 53f5538 Author: Ward Bell <[email protected]> Date: Mon Nov 14 09:28:40 2016 -0800 feat(cb-ts-to-js): add es6 examples (angular#2606) * feat(cb-ts-to-js): add es6 examples update docshredder to shred .es6 optimized focus gulp task convert imports and metadate sections add DI section add host and query metadata section add intro fix capitalization and grammar * docs(ts-to-js): ward's edits (incomplete) * docs(ts-to-js): add separate template files for some components * docs(cb-ts-to-js): refactor sample code commit 53f5538 Author: Ward Bell <[email protected]> Date: Sun Nov 13 14:09:28 2016 -0800 docs(cb-ts-to-js): refactor sample code commit 9e9666b Author: Patrice Chalin <[email protected]> Date: Mon Nov 14 08:34:10 2016 -0800 docs(template-syntax/dart): updates to match TS (angular#2751) * docs(template-syntax): refresh _cache * docs(template-syntax/dart): updates to match TS - Propagates TS-side changes: - update angular#2639 - new two-way binding section, and - fix angular#2687 - invalid attr syntax - Fixes - angular#1898 - currency symbols - angular#2748 - Dart template-syntax e2e is failing - angular#2749 - deprecated `[className]` * updated _cache file following Kathy's post-review edits * Post Ward's review w/ cache updated - Keep `my-` and `my` prefixes on selectors (for components and directives, respectively). - Drop `my-` from file names. - Drop `My` as component class prefix. commit 5dcffd6 Author: Patrice Chalin <[email protected]> Date: Sun Nov 13 19:37:13 2016 -0800 docs: dart glossary - fix misnamed Jade block commit 6680acc Merge: 14db838 3b03573 Author: Kathy Walrath <[email protected]> Date: Mon Nov 14 08:31:11 2016 -0800 docs(toh): avoid dup header title (angular#2796) * remove redundant headings * update _cache * misc: make block comment a Jade comment (This prevents the text from appearing in the generated HTML as an HTML comment.) commit 3b03573 Author: Patrice Chalin <[email protected]> Date: Mon Nov 14 05:30:05 2016 -0800 misc: make block comment a Jade comment (This prevents the text from appearing in the generated HTML as an HTML comment.) commit 470426d Author: Patrice Chalin <[email protected]> Date: Mon Nov 14 05:25:36 2016 -0800 update _cache commit c12d75a Author: Patrice Chalin <[email protected]> Date: Mon Nov 14 05:23:35 2016 -0800 remove redundant headings commit 85062c4 Author: Patrice Chalin <[email protected]> Date: Mon Nov 14 04:56:12 2016 -0800 chore(util.js): getExampleName - support optional .html suffix commit 02f5559 Author: Patrice Chalin <[email protected]> Date: Mon Nov 14 04:29:17 2016 -0800 docs: guide/index misc Jade fixes - Eliminate use of deprecated `clear=“all”` in `<br>`. - No need for local `langName`; use global `_Lang` var instead. - Remove duplicate id `learning-path`. commit 14db838 Author: Naomi Black <[email protected]> Date: Sun Nov 13 21:48:52 2016 -0500 news(nov): Some news and a blog post update commit eff32ec Author: Naomi Black <[email protected]> Date: Sun Nov 13 21:48:37 2016 -0500 chore(bios): update some bios for leads commit 3ee36fb Author: koyner <[email protected]> Date: Sun Nov 13 22:59:59 2016 +0100 docs(forms): grammar fix (angular#2764) commit b11438f Author: Ward Bell <[email protected]> Date: Fri Nov 11 19:44:00 2016 -0800 docs(ts-to-js): add separate template files for some components commit 33b6197 Author: Ward Bell <[email protected]> Date: Thu Nov 3 01:37:55 2016 -0700 docs(ts-to-js): ward's edits (incomplete) commit 12eb19f Author: Filipe Silva <[email protected]> Date: Thu Oct 13 17:59:00 2016 +0100 feat(cb-ts-to-js): add es6 examples update docshredder to shred .es6 optimized focus gulp task convert imports and metadate sections add DI section add host and query metadata section add intro fix capitalization and grammar commit 64a8754 Author: Patrice Chalin <[email protected]> Date: Thu Nov 10 20:01:36 2016 -0800 example(template-syntax): follow style-guide and other updates (angular#2750) commit 7619cdf Author: Jesús Rodríguez <[email protected]> Date: Thu Nov 10 23:47:30 2016 +0100 chore: ability to open a plunker on a specific file (angular#2778) commit 0161d9d Author: Filipe Silva <[email protected]> Date: Thu Nov 10 22:45:22 2016 +0000 chore: ignore debug.log file (angular#2785) This file is generated when running `gulp e2e` and often enough committed by mistake. /cc @Foxandxss commit f92983c Author: Jesús Rodríguez <[email protected]> Date: Thu Nov 10 23:44:51 2016 +0100 docs(ngmodule): fix plunkers (angular#2786) commit 03db4bb Author: Martin Eckardt <[email protected]> Date: Wed Nov 9 17:43:40 2016 +0100 docs(a1-a2): fix link to Filter/Pipes (angular#2770) commit 60565a5 Author: Pavol Pitonak <[email protected]> Date: Wed Nov 9 17:42:57 2016 +0100 docs(testing): configureTestModule -> configureTestingModule (angular#2767) commit ec47197 Author: Catalin Zalog <[email protected]> Date: Wed Nov 9 18:41:56 2016 +0200 docs(style-guide): fix missing *.ts (angular#2763) commit 234e468 Author: Patrice Chalin <[email protected]> Date: Tue Nov 8 08:21:02 2016 -0800 docs: intra-site links should be relative Contributes to angular#2772. commit 6b37da7 Author: Patrice Chalin <[email protected]> Date: Tue Nov 8 09:27:10 2016 -0800 docs(forms/dart): remove mention of FORM_DIRECTIVES Fixes angular#2752 commit c24dd07 Author: Patrice Chalin <[email protected]> Date: Tue Nov 8 14:48:03 2016 -0800 docs(toh-5/dart): use routerLink in dashboard (angular#2744) * docs(toh-5/dart): use routerLink in dashboard * minor edits to TS jade * remove dart/toh-pt5 from bad-code-excerpt-skip-patterns commit 2808878 Author: Patrice Chalin <[email protected]> Date: Tue Nov 8 07:41:27 2016 -0800 chore(deploy): don't name project in firebase deploy Naming the project would sometimes cause gulp to report `An unexpected error has occurred` with exit code 2. commit 2649647 Author: Jesus Rodriguez <[email protected]> Date: Sat Nov 5 00:37:47 2016 +0100 chore: add upgrade/static to API reference commit 8508140 Merge: 37f93bc b1c2c27 Author: Adrian Irwin <[email protected]> Date: Thu Nov 3 17:27:43 2016 -0700 Merge branch 'router' of https://github.com/adrianirwin/angular.io into router commit 37f93bc Author: Adrian Irwin <[email protected]> Date: Thu Nov 3 17:25:55 2016 -0700 docs(router): fixed verbiage and example of how routed views are related to the router outlet commit b1c2c27 Author: Adrian Irwin <[email protected]> Date: Thu Nov 3 16:57:56 2016 -0700 docs(router): fixed verbiage and example of how routed views are related to the router outlet
filipesilva
added a commit
that referenced
this pull request
Nov 15, 2016
* re-enable upgrade-adapter and upgrade-phonecat-1 tests * re-enable upgrade-phonecat-2 tests * add hybrid toggle switch to helpers * use 2.2.0-rc.0 * revert change to browser.ignoreSynchronization * convert 1-2-hybrid-bootstrap to upgrade/static * remove shared adapter example * add systemjs config extras to all indexes * update upgrade-static * update upgrade-io example * update downgrade-static * update downgrade-io * update 1-to-2-projection * update 2-to-1-transclusion * update 1-to-2-providers * update 2-to-1-providers * cleanup upgrade-adapter e2e test * re-enable upgrade-adapter tests * change HeroDetailComponent to HeroDetailDirective * fix missing systemjs.config.extras * add typing to UpgradeModule DI * update upgrade-phonecat-2-hybrid * update upgrade-adapter's prose * rename upgrade-adapter example to upgrade-module * improve angular1 type declaration in hybrid apps * remove unused imports in protractor-helpers * update phonecat-hybrid bootstrap prose * update phonecat-hybrid service and components * update phonecat-final prose * update e2e prose * update systemjs.config.js to have @angular/upgrade/static by default * add aot (WIP) * remove wip aot changes from test run * change let to const in bootstrap * elaborate upgraded component alert * use 2.2.0 versions instead of rc0 * Squashed commit of the following: commit 17c7e15 Author: Filipe Silva <[email protected]> Date: Mon Nov 14 23:11:37 2016 +0000 chore: update to 2.2.0 (#2797) commit 1e5facf Merge: 5c4cc9a db0fac9 Author: Ward Bell <[email protected]> Date: Mon Nov 14 12:44:51 2016 -0800 Merge pull request #2799 from IdeaBlade/docs-changelog-2.2.0 chore(changelog): update docs changelog for Ng v.2.2.0 commit 5c4cc9a Merge: 43457e9 1afe5dc Author: Ward Bell <[email protected]> Date: Mon Nov 14 12:43:09 2016 -0800 docs(router): Updated usage of observables in router tutorial and developer guide (#2696) Moved route configuration into separate variable for consistency Added async pipe to handle subscriptions for list items commit 43457e9 Merge: a423a5a 2649647 Author: Jesús Rodríguez <[email protected]> Date: Mon Nov 14 21:38:49 2016 +0100 chore: add upgrade/static to API reference (#2755) commit 1afe5dc Author: Brandon Roberts <[email protected]> Date: Sat Oct 29 16:08:54 2016 -0500 docs(router): Updated usage of observables in router tutorial and developer guide Moved route configuration into separate variable for consistency Added async pipe to handle subscriptions for list items commit db0fac9 Author: Ward Bell <[email protected]> Date: Mon Nov 14 10:48:09 2016 -0800 chore(changelog): update docs changelog for Ng v.2.2.0 commit a423a5a Author: ikilled <[email protected]> Date: Mon Nov 14 18:39:46 2016 +0000 clicking on Books & Training sends user to Education (#2701) When user clicks in Books & Training item in footer the website should take them to Education section (anchor) in the middle of the page, not to the top where Development section is. commit d63b1cc Merge: f627706 8508140 Author: Ward Bell <[email protected]> Date: Mon Nov 14 10:35:48 2016 -0800 docs(router): fixed verbiage about router-outlet (#2746) commit f627706 Author: Ward Bell <[email protected]> Date: Mon Nov 14 10:26:13 2016 -0800 docs(cookbook-aot-compiler): improve Ahead-of-Time compilation cookbook (#2798) closes #2790 commit 75464d5 Merge: 78e2584 02f5559 Author: Ward Bell <[email protected]> Date: Mon Nov 14 09:34:36 2016 -0800 Merge pull request #2794 from IdeaBlade/chalin-guide-misc-fix-1113 docs: guide/index misc Jade fixes commit 78e2584 Merge: 182493f 85062c4 Author: Ward Bell <[email protected]> Date: Mon Nov 14 09:33:55 2016 -0800 Merge pull request #2795 from IdeaBlade/chalin-util-js-getExampleName-1114 chore(util.js): getExampleName - support optional .html suffix commit 182493f Merge: 9e9666b 53f5538 Author: Ward Bell <[email protected]> Date: Mon Nov 14 09:28:40 2016 -0800 feat(cb-ts-to-js): add es6 examples (#2606) * feat(cb-ts-to-js): add es6 examples update docshredder to shred .es6 optimized focus gulp task convert imports and metadate sections add DI section add host and query metadata section add intro fix capitalization and grammar * docs(ts-to-js): ward's edits (incomplete) * docs(ts-to-js): add separate template files for some components * docs(cb-ts-to-js): refactor sample code commit 53f5538 Author: Ward Bell <[email protected]> Date: Sun Nov 13 14:09:28 2016 -0800 docs(cb-ts-to-js): refactor sample code commit 9e9666b Author: Patrice Chalin <[email protected]> Date: Mon Nov 14 08:34:10 2016 -0800 docs(template-syntax/dart): updates to match TS (#2751) * docs(template-syntax): refresh _cache * docs(template-syntax/dart): updates to match TS - Propagates TS-side changes: - update #2639 - new two-way binding section, and - fix #2687 - invalid attr syntax - Fixes - #1898 - currency symbols - #2748 - Dart template-syntax e2e is failing - #2749 - deprecated `[className]` * updated _cache file following Kathy's post-review edits * Post Ward's review w/ cache updated - Keep `my-` and `my` prefixes on selectors (for components and directives, respectively). - Drop `my-` from file names. - Drop `My` as component class prefix. commit 5dcffd6 Author: Patrice Chalin <[email protected]> Date: Sun Nov 13 19:37:13 2016 -0800 docs: dart glossary - fix misnamed Jade block commit 6680acc Merge: 14db838 3b03573 Author: Kathy Walrath <[email protected]> Date: Mon Nov 14 08:31:11 2016 -0800 docs(toh): avoid dup header title (#2796) * remove redundant headings * update _cache * misc: make block comment a Jade comment (This prevents the text from appearing in the generated HTML as an HTML comment.) commit 3b03573 Author: Patrice Chalin <[email protected]> Date: Mon Nov 14 05:30:05 2016 -0800 misc: make block comment a Jade comment (This prevents the text from appearing in the generated HTML as an HTML comment.) commit 470426d Author: Patrice Chalin <[email protected]> Date: Mon Nov 14 05:25:36 2016 -0800 update _cache commit c12d75a Author: Patrice Chalin <[email protected]> Date: Mon Nov 14 05:23:35 2016 -0800 remove redundant headings commit 85062c4 Author: Patrice Chalin <[email protected]> Date: Mon Nov 14 04:56:12 2016 -0800 chore(util.js): getExampleName - support optional .html suffix commit 02f5559 Author: Patrice Chalin <[email protected]> Date: Mon Nov 14 04:29:17 2016 -0800 docs: guide/index misc Jade fixes - Eliminate use of deprecated `clear=“all”` in `<br>`. - No need for local `langName`; use global `_Lang` var instead. - Remove duplicate id `learning-path`. commit 14db838 Author: Naomi Black <[email protected]> Date: Sun Nov 13 21:48:52 2016 -0500 news(nov): Some news and a blog post update commit eff32ec Author: Naomi Black <[email protected]> Date: Sun Nov 13 21:48:37 2016 -0500 chore(bios): update some bios for leads commit 3ee36fb Author: koyner <[email protected]> Date: Sun Nov 13 22:59:59 2016 +0100 docs(forms): grammar fix (#2764) commit b11438f Author: Ward Bell <[email protected]> Date: Fri Nov 11 19:44:00 2016 -0800 docs(ts-to-js): add separate template files for some components commit 33b6197 Author: Ward Bell <[email protected]> Date: Thu Nov 3 01:37:55 2016 -0700 docs(ts-to-js): ward's edits (incomplete) commit 12eb19f Author: Filipe Silva <[email protected]> Date: Thu Oct 13 17:59:00 2016 +0100 feat(cb-ts-to-js): add es6 examples update docshredder to shred .es6 optimized focus gulp task convert imports and metadate sections add DI section add host and query metadata section add intro fix capitalization and grammar commit 64a8754 Author: Patrice Chalin <[email protected]> Date: Thu Nov 10 20:01:36 2016 -0800 example(template-syntax): follow style-guide and other updates (#2750) commit 7619cdf Author: Jesús Rodríguez <[email protected]> Date: Thu Nov 10 23:47:30 2016 +0100 chore: ability to open a plunker on a specific file (#2778) commit 0161d9d Author: Filipe Silva <[email protected]> Date: Thu Nov 10 22:45:22 2016 +0000 chore: ignore debug.log file (#2785) This file is generated when running `gulp e2e` and often enough committed by mistake. /cc @Foxandxss commit f92983c Author: Jesús Rodríguez <[email protected]> Date: Thu Nov 10 23:44:51 2016 +0100 docs(ngmodule): fix plunkers (#2786) commit 03db4bb Author: Martin Eckardt <[email protected]> Date: Wed Nov 9 17:43:40 2016 +0100 docs(a1-a2): fix link to Filter/Pipes (#2770) commit 60565a5 Author: Pavol Pitonak <[email protected]> Date: Wed Nov 9 17:42:57 2016 +0100 docs(testing): configureTestModule -> configureTestingModule (#2767) commit ec47197 Author: Catalin Zalog <[email protected]> Date: Wed Nov 9 18:41:56 2016 +0200 docs(style-guide): fix missing *.ts (#2763) commit 234e468 Author: Patrice Chalin <[email protected]> Date: Tue Nov 8 08:21:02 2016 -0800 docs: intra-site links should be relative Contributes to #2772. commit 6b37da7 Author: Patrice Chalin <[email protected]> Date: Tue Nov 8 09:27:10 2016 -0800 docs(forms/dart): remove mention of FORM_DIRECTIVES Fixes #2752 commit c24dd07 Author: Patrice Chalin <[email protected]> Date: Tue Nov 8 14:48:03 2016 -0800 docs(toh-5/dart): use routerLink in dashboard (#2744) * docs(toh-5/dart): use routerLink in dashboard * minor edits to TS jade * remove dart/toh-pt5 from bad-code-excerpt-skip-patterns commit 2808878 Author: Patrice Chalin <[email protected]> Date: Tue Nov 8 07:41:27 2016 -0800 chore(deploy): don't name project in firebase deploy Naming the project would sometimes cause gulp to report `An unexpected error has occurred` with exit code 2. commit 2649647 Author: Jesus Rodriguez <[email protected]> Date: Sat Nov 5 00:37:47 2016 +0100 chore: add upgrade/static to API reference commit 8508140 Merge: 37f93bc b1c2c27 Author: Adrian Irwin <[email protected]> Date: Thu Nov 3 17:27:43 2016 -0700 Merge branch 'router' of https://github.com/adrianirwin/angular.io into router commit 37f93bc Author: Adrian Irwin <[email protected]> Date: Thu Nov 3 17:25:55 2016 -0700 docs(router): fixed verbiage and example of how routed views are related to the router outlet commit b1c2c27 Author: Adrian Irwin <[email protected]> Date: Thu Nov 3 16:57:56 2016 -0700 docs(router): fixed verbiage and example of how routed views are related to the router outlet * deactivate bugged tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2775
Contributes to #998