Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

docs(server-communication): Resolve todo #1993

Merged
merged 2 commits into from
Aug 1, 2016
Merged

docs(server-communication): Resolve todo #1993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9baa6b3
use latest version of http_in_memory_web_api
adaojunior Jul 28, 2016
d2e6046
remove todo and drop the ?? body term
adaojunior Jul 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions public/docs/_examples/server-communication/dart/lib/toh/hero_service.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,7 @@ class HeroService {
// #docregion extract-data
dynamic _extractData(Response res) {
var body = JSON.decode(res.body);
// TODO: https://github.com/adaojunior/http-in-memory-web-api/issues/1
// Once #1 is fixed, drop the `?? body` term:
return body['data'] ?? body;
return body['data'];
}
// #enddocregion extract-data
// #docregion error-handling
Expand Down
2 changes: 1 addition & 1 deletion public/docs/_examples/server-communication/dart/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ dependencies:
http: ^0.11.3+3
jsonpadding: ^0.1.0
stream_transformers: ^0.3.0+3
http_in_memory_web_api: ^0.0.1
http_in_memory_web_api: ^0.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this, @chalin ? Otherwise this PR makes sense to me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wardbell : there was a bug in http_in_memory_web_api which the author fixed. This PR removes the temporary workaround and bumps up the library version to get the fixed version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is http_in_memory_web_api? I guess this is all Dart so I shouldn't care ;-)

Copy link
Contributor Author

@adaojunior adaojunior Aug 1, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wardbell this is a port of a2-in-memory-web-api that you wrote.

http-in-memory-web-api

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is an all-Dart counterpart.

# #docregion transformers
transformers:
- angular2:
Expand Down