This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(server-communication): Resolve todo #1993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, LGTM |
| @@ -11,7 +11,7 @@ dependencies: | |||
| http: ^0.11.3+3 | |||
| jsonpadding: ^0.1.0 | |||
| stream_transformers: ^0.3.0+3 | |||
| http_in_memory_web_api: ^0.0.1 | |||
| http_in_memory_web_api: ^0.2.0 | |||
There was a problem hiding this comment.
What is this, @chalin ? Otherwise this PR makes sense to me.
There was a problem hiding this comment.
@wardbell : there was a bug in http_in_memory_web_api which the author fixed. This PR removes the temporary workaround and bumps up the library version to get the fixed version.
There was a problem hiding this comment.
what is http_in_memory_web_api? I guess this is all Dart so I shouldn't care ;-)
There was a problem hiding this comment.
@wardbell this is a port of a2-in-memory-web-api that you wrote.
There was a problem hiding this comment.
Yes, it is an all-Dart counterpart.
|
I'll merge this now unless someone screams... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.