-
Notifications
You must be signed in to change notification settings - Fork 877
docs(toh-5/dart): review edits and code cleanup #1643
docs(toh-5/dart): review edits and code cleanup #1643
Conversation
9061fda
to
c50d805
Compare
8dde8eb
to
ebb6ad7
Compare
ebb6ad7
to
8203d4e
Compare
* add routing | ||
* create a new `DashboardComponent` | ||
* tie the *Dashboard* into the navigation structure. | ||
* turn `AppComponent` into an application shell that only handles navigation, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're editing this, I'd use sentence caps but not add commas at the end. (Periods would be fine, though.) I'd also add a colon after "plan". For example:
Here's our plan:
- Turn ... navigation.
- ...
- Tie ... structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is my preference too. Done.
The changes look good, with the exception of what I commented on. (This page needs a good copy edit, but I tried to avoid looking at anything you didn't change!) |
I agree about further copy edits. For now, I have addressed the points that you raised, and made the changes to both the TS and Dart sides so that they match. |
LGTM. Merging now... |
Code:
Contributing to #1628.