Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

docs(toh-5/dart): review edits and code cleanup #1643

Merged
merged 2 commits into from
Jun 15, 2016

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jun 10, 2016

  • Adjust text which used to say "create a new 'styles.css'" when we've been carrying it around since QuickStart.
  • The HTTP tutorial chapter is no longer "forthcoming".
  • This commit also adds a missing docregion to a toh-4 file that is referrenced in toh-5.
  • Fixed prose over indentation (which appeared in over half the file).
  • Copyedits.

Code:

  • Add missing return types.
  • Handle invalid numeric route hero ids.
  • Rename HERO mockHeroes as used in earlier tutorial chapters.
  • Use Dartisms (cleanup from ts2dart transpilation).

Contributing to #1628.

@chalin
Copy link
Contributor Author

chalin commented Jun 10, 2016

@kwalrath @thso : prose and code changes are ready for review.

@chalin chalin force-pushed the chalin-toh-5-dart-minor-edits-0609 branch from 9061fda to c50d805 Compare June 10, 2016 16:34
@chalin chalin mentioned this pull request Jun 10, 2016
6 tasks
@chalin chalin force-pushed the chalin-toh-5-dart-minor-edits-0609 branch 2 times, most recently from 8dde8eb to ebb6ad7 Compare June 13, 2016 20:58
@chalin chalin force-pushed the chalin-toh-5-dart-minor-edits-0609 branch from ebb6ad7 to 8203d4e Compare June 14, 2016 16:35
* add routing
* create a new `DashboardComponent`
* tie the *Dashboard* into the navigation structure.
* turn `AppComponent` into an application shell that only handles navigation,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're editing this, I'd use sentence caps but not add commas at the end. (Periods would be fine, though.) I'd also add a colon after "plan". For example:

Here's our plan:

  • Turn ... navigation.
  • ...
  • Tie ... structure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is my preference too. Done.

@kwalrath
Copy link
Contributor

The changes look good, with the exception of what I commented on. (This page needs a good copy edit, but I tried to avoid looking at anything you didn't change!)

@chalin
Copy link
Contributor Author

chalin commented Jun 15, 2016

I agree about further copy edits. For now, I have addressed the points that you raised, and made the changes to both the TS and Dart sides so that they match.

@kwalrath
Copy link
Contributor

LGTM. Merging now...

@kwalrath kwalrath merged commit 6e5d8e6 into angular:master Jun 15, 2016
@chalin chalin deleted the chalin-toh-5-dart-minor-edits-0609 branch June 15, 2016 20:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants