Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Dart heroes tutorial source is inconsistent #1651

Closed
sturmf opened this issue Jun 12, 2016 · 2 comments
Closed

Dart heroes tutorial source is inconsistent #1651

sturmf opened this issue Jun 12, 2016 · 2 comments
Labels

Comments

@sturmf
Copy link

sturmf commented Jun 12, 2016

Hi, one more small inconsistency in the heroes tutorial. Between

https://github.com/angular/angular.io/blob/master/public/docs/_examples/toh-4/dart/lib/mock_heroes.dart

and

https://github.com/angular/angular.io/blob/master/public/docs/_examples/toh-5/dart/lib/mock_heroes.dart

you change the definition from final List mockHeroes to final List HEROES. This can be confusing for beginners.

@chalin Btw. I hope it's ok me reporting these issues, if not, I will stop. Besides this the tutorial is great! And I am eagerly awaiting the next chapters for dart.

@chalin
Copy link
Contributor

chalin commented Jun 12, 2016

Hi Fabian: please continue to report such issues; this kind of feedback is greatly appreciated :).

You are right, there is a switch in name. The issue will have been fixed once #1643 is merged; e.g. see https://github.com/angular/angular.io/pull/1643/files#diff-94b44f4a8e4e22d08e9d2410a861de6bL10

@kwalrath
Copy link
Contributor

#1643 has been merged. It might take a few days for the change to appear on the website.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants