This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(basics/di): minor edits following TS switch to provider object literal #1600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works for me |
chalin
force-pushed
the
chalin-dart-basics-di-0604
branch
2 times, most recently
from
70e577e to
6387b56
Compare
|
@kwalrath : anything left to do here? |
…iteral Minor edits: - Dart side adjustments following angular#1594. - Renamed example '3a' to just '3' and tweaked the logger message - Removed obsolete Dart block.
chalin
force-pushed
the
chalin-dart-basics-di-0604
branch
from
6387b56 to
b65415e
Compare
|
I got distracted trying to make my doc build work. It's still broken, but I won't let that hold up this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor edits:
TS and Dart DI e2e tests pass.