This repository was archived by the owner on Dec 4, 2017. It is now read-only.
chore: move to provide object literal #1594
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like I left some behind, working on that. |
|
I took a quick look; @chalin will take a closer one. |
|
@Foxandxss : let me know once this is ready for review. |
|
I definitely broke the Dart part, but @chalin will fix it when this hit master. |
|
Also changed a blue box where it explains differences from Dart to Typescript in regard of provide. I changed the prose there, but feel free to change it too. |
|
Proceeding with the agreement that @chalin will fix what we broke in Dart at his convenience. |
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Jun 4, 2016
…iteral Minor edits: - Dart side adjustments following angular#1594. - Renamed example '3a' to just '3' and tweaked the logger message - Removed obsolete Dart block.
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Jun 7, 2016
…iteral Minor edits: - Dart side adjustments following angular#1594. - Renamed example '3a' to just '3' and tweaked the logger message - Removed obsolete Dart block.
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Jun 8, 2016
…iteral Minor edits: - Dart side adjustments following angular#1594. - Renamed example '3a' to just '3' and tweaked the logger message - Removed obsolete Dart block.
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Jun 8, 2016
…iteral Minor edits: - Dart side adjustments following angular#1594. - Renamed example '3a' to just '3' and tweaked the logger message - Removed obsolete Dart block.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the "provided object literal" to define this new syntax. We were using it already and I agreed with it.
I removed two examples from
dependency injectionand touched Dart prose and one of the files so please @chalin or @kwalrath confirm that I didn't break it.Removing two examples the numbers jump from example 1 to example 3a, but that is just internal. I can fix the numbers if needed.