This repository was archived by the owner on Dec 4, 2017. It is now read-only.
chore(dart): pipes example rolled back to beta.15 #1220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
changed the title
| : int.parse(args.first.toString(), onError: (source) => 1); | ||
| return math.pow(v, p); | ||
| } | ||
| /* beta.15+ |
There was a problem hiding this comment.
Please remove, we can easily find this code back if needed.
Link to Dart beta.16 update: 0557c72
|
Let's just remove the commented out code, but otherwise LGTM. |
The pipes example stopped working in beta.16; this rolls it back to the last known working version. See earlier commit for code changes necessary in support of beta.16: angular@0557c728d75e519bc6846b37492 414dff540c6ee
chalin
force-pushed
the
chalin-guide-pipes-rollback
branch
from
dfb2945 to
7d79afd
Compare
|
Done. |
chalin
changed the title
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Apr 30, 2016
Changed `ngFor=“#…”` to `ngFor=“let…` in code. All are .dart files except for `app_component.html` which also has changes for: - `<inpuf var-foo…`> to `<input ref-foo…>` - `#docregion` tag name updates from var-foo to ref-foo. - Other misc updates to minimize diffs with TS version of file (though I ignored whitespace differences). Note that guide/pipes was not updated; it will be rolled back to beta.15 in PR angular#1220.
thso
pushed a commit
that referenced
this pull request
Apr 30, 2016
Change `ngFor=“#…”` to `ngFor=“let…` in code. All are .dart files except for `app_component.html` which also has changes for: - `<inpuf var-foo…`> to `<input ref-foo…>` - `#docregion` tag name updates from var-foo to ref-foo. - Other misc updates to minimize diffs with TS version of file, whitespace differences were ignored. + Minor update to sync up Dart prose with TS prose. + Used https://github.com/angular/angular/wiki/Angular-2-Dart-Transformer#resol ved_identifiers to solve #1033 Guide/pipes not updated as it will be rolled back to beta.15 in PR #1220.
|
LGTM |
thelgevold
added a commit
to IdeaBlade/angular.io
that referenced
this pull request
May 4, 2016
text feat(resources): add more pages. Increase font size. Rename in footer. All encompassing resource page chore(resources): update resources links and header and footer chore(presskit): make reuse permissions more clear chore(dart & ts): update to beta.17 Change `ngFor=“#…”` to `ngFor=“let…` in code. All are .dart files except for `app_component.html` which also has changes for: - `<inpuf var-foo…`> to `<input ref-foo…>` - `#docregion` tag name updates from var-foo to ref-foo. - Other misc updates to minimize diffs with TS version of file, whitespace differences were ignored. + Minor update to sync up Dart prose with TS prose. + Used https://github.com/angular/angular/wiki/Angular-2-Dart-Transformer#resol ved_identifiers to solve angular#1033 Guide/pipes not updated as it will be rolled back to beta.15 in PR angular#1220. chore(dart): pipes example rolled back to beta.15 The pipes example stopped working in beta.16; roll it back to the last known working version. See earlier commit for code changes necessary in support of beta.16: angular@0557c728d75e519bc6846b37492 414dff540c6ee docs(style-guide): add style-guide - v.5 docs: rename heros to heroes docs(lifecycle-hooks): update directive selector to camelCase closes angular#1236 docs(style-guide): add style-guide - v.6 docs: fix a few typos closes angular#1239 docs(style-guide): fix merge issues closes angular#1244 chore(updates): update resources and livestream hero chore(dgeni): update dgeni to handle repackaging changes feat(images): new frontpage as directed by Alex Wolfe. New images from Fatima Remtullah chore(hero): update hero banner for ngconf livestream feat(features: update features section) chore(dgeni): update dgeni to serve old and new router chore(copyedit): copyedits to feature page text feat(docs landing): new docs landing converts docs landing template to use layout classnames rather than attribute syntax chore: update to rc.0 docs: switch to commonjs module generation docs(style-guide): revisions for New World (repack) closes angular#1260 docs(samples): removed unused typings excludes from tsconfig docs(router): samples and doc for new router (phase 1) docs: update all docs to partially comply the style-guide docs(router): document new router and samples - phase 2 docs(quickstart): fix misplaced close paren docs(npm-packages): typo ES6 = ES2015 closes angular#1263 docs(quickstart.jade): Modify "Typescript type definition file" link up-to-date url closes angular#1262 docs(pipes): change description for parameters to reflect change in beta.16 closes angular#1197 docs(style-guide): fix some typos closes angular#1275 docs(style-guide): fix some typos (missed one) docs(ts/js): update to rc1 upgrade to rc1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev guide pipes stopped working in beta.16; this rolls it back to the last known working version (beta.15).