Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Dart server-communication sample is broken #1033

Closed
kwalrath opened this issue Mar 31, 2016 · 1 comment
Closed

Dart server-communication sample is broken #1033

kwalrath opened this issue Mar 31, 2016 · 1 comment

Comments

@kwalrath
Copy link
Contributor

It hasn't worked for a while. (I'm not positive it ever worked.)

https://github.com/angular/angular.io/tree/master/public/docs/_examples/server-communication/dart

Contributions welcome...

@chalin
Copy link
Contributor

chalin commented Apr 30, 2016

Under beta.17, a pub build yields:

Loading source assets...
Loading angular2/transform/codegen, dart_to_js_script_rewriter, observe and smoke/src/default_transformer transformers...
Loading angular2 transformers...
Building server_communication...
[Error from DirectiveMetadataLinker on server_communication|lib/toh/hero_service.ng_summary.json with input server_communication|lib/toh/hero_service.ng_meta.json]:
Missing identifier "BrowserClient" needed by "HeroService" from metadata map
[Error from DirectiveMetadataLinker on server_communication|lib/toh/toh_component.ng_summary.json with input server_communication|lib/toh/toh_component.ng_meta.json]:
Missing identifier "BrowserClient" needed by "TohComponent" from metadata map
[Info from Dart2JS]:
Compiling server_communication|web/main.dart...
[Error from Dart2JS on server_communication|web/main.dart]:
web/main.ngfactory.dart:8:1:
Can't read 'package:server_communication/toh/toh_component.ngfactory.dart' (Could not find asset server_communication|lib/toh/toh_component.ngfactory.dart.).
import 'package:server_communication/toh/toh_component.ngfactory.dart' as i1;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[Dart2JS]:
web/main.dart:

This problem ("Missing identifier ..."), and its solution are documented in https://github.com/angular/angular/wiki/Angular-2-Dart-Transformer#resolved_identifiers

The app works once more after updating the pubspec.yaml to (only excerpts shown):

name: server_communication ...
dependencies:
  angular2: 2.0.0-beta.17 ...
transformers:
- angular2: ...
    resolved_identifiers:
        BrowserClient: 'package:http/browser_client.dart'

Fixed in #1219.

cf. angular/angular#8189

thso pushed a commit that referenced this issue Apr 30, 2016
Change `ngFor=“#…”` to `ngFor=“let…` in code. All are .dart files
except for `app_component.html` which also has changes for:
- `<inpuf var-foo…`> to `<input ref-foo…>`
- `#docregion` tag name updates from var-foo to ref-foo.
- Other misc updates to minimize diffs with TS version of file,
whitespace differences were ignored.

+ Minor update to sync up Dart prose with TS prose.

+ Used
https://github.com/angular/angular/wiki/Angular-2-Dart-Transformer#resol
ved_identifiers to solve
#1033

Guide/pipes not updated as it will be rolled back to
beta.15 in PR #1220.
@thso thso closed this as completed Apr 30, 2016
thelgevold added a commit to IdeaBlade/angular.io that referenced this issue May 4, 2016
text

feat(resources): add more pages. Increase font size. Rename in footer. All encompassing resource page

chore(resources): update resources links and header and footer

chore(presskit): make reuse permissions more clear

chore(dart & ts): update to beta.17

Change `ngFor=“#…”` to `ngFor=“let…` in code. All are .dart files
except for `app_component.html` which also has changes for:
- `<inpuf var-foo…`> to `<input ref-foo…>`
- `#docregion` tag name updates from var-foo to ref-foo.
- Other misc updates to minimize diffs with TS version of file,
whitespace differences were ignored.

+ Minor update to sync up Dart prose with TS prose.

+ Used
https://github.com/angular/angular/wiki/Angular-2-Dart-Transformer#resol
ved_identifiers to solve
angular#1033

Guide/pipes not updated as it will be rolled back to
beta.15 in PR angular#1220.

chore(dart): pipes example rolled back to beta.15

The pipes example stopped working in beta.16; roll it back to the
last known working version.

See earlier commit for code changes necessary in support of beta.16:
angular@0557c728d75e519bc6846b37492
414dff540c6ee

docs(style-guide): add style-guide - v.5

docs: rename heros to heroes

docs(lifecycle-hooks): update directive selector to camelCase
closes angular#1236

docs(style-guide): add style-guide - v.6

docs: fix a few typos
closes angular#1239

docs(style-guide): fix merge issues
closes angular#1244

chore(updates): update resources and livestream hero

chore(dgeni): update dgeni to handle repackaging changes

feat(images): new frontpage as directed by Alex Wolfe. New images from Fatima Remtullah

chore(hero): update hero banner for ngconf livestream

feat(features: update features section)

chore(dgeni): update dgeni to serve old and new router

chore(copyedit): copyedits to feature page text

feat(docs landing): new docs landing

converts docs landing template to use layout classnames rather than attribute syntax

chore: update to rc.0

docs: switch to commonjs module generation

docs(style-guide): revisions for New World (repack)
closes angular#1260

docs(samples): removed unused typings excludes from tsconfig

docs(router): samples and doc for new router (phase 1)

docs: update all docs to partially comply the style-guide

docs(router): document new router and samples - phase 2

docs(quickstart): fix misplaced close paren

docs(npm-packages): typo ES6 = ES2015
closes angular#1263

docs(quickstart.jade): Modify "Typescript type definition file" link up-to-date url
closes angular#1262

docs(pipes): change description for parameters to reflect change in beta.16
closes angular#1197

docs(style-guide): fix some typos
closes angular#1275

docs(style-guide): fix some typos (missed one)

docs(ts/js): update to rc1

upgrade to rc1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants