fix: Respect build assets allowOutsideOutdir

[trendzetter]

The old check should be removed so assets are allowed outside the project folder if allowOutsideOutdir is configured.
Fixes #9363

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
• If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
• In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

[trendzetter]

I signed it!

[googlebot]

CLAs look good, thanks!

[clydin]

That's not an old check. It's intentional and helps to prevent writing to arbitrary locations on the filesystem.

[trendzetter]

@clydin: It's checked twice. Once taking into account the optional configuration and the other is not taking into account a valid configuration directive

[clydin]

It's not checked twice; they are two different checks. The first check verifies it is within the outputPath for the app. If it is not, then the second check verifies if it is within the project itself. Then it checks if assets are allowed to be written outside the outputPath (but still within the project due to the previous check).

[yuvalbl]

This solution seems to cause an issue
See my comment on related item

[trendzetter]

@yuvalbl It's not merged, is it?

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}