Skip to content

allowOutsideOutDir for assets not working again #9363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trendzetter opened this issue Jan 24, 2018 · 5 comments
Closed

allowOutsideOutDir for assets not working again #9363

trendzetter opened this issue Jan 24, 2018 · 5 comments
Labels
effort1: easy (hours) P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful severity5: regression type: bug/fix

Comments

@trendzetter
Copy link

trendzetter commented Jan 24, 2018

Versions

Tested on:
1.6.3
1.6.5
Windows 10

Repro steps

  • npm install -G @angular/cli

  • cd to project with assets that need to be copied outside the project folder. From the .angular-cli.json:
    "assets": [{
    "input": "./assets/",
    "glob": "**/*",
    "output": "../EcView/WebContent/assets",
    "allowOutsideOutDir": true
    }],

  • ng build

Observed behavior

Build failed:

>ng build
An asset cannot be written to a location outside the project.

Desired behavior

The build process copies the assets to the specified folder and completes the compilation of source code.

Other details

Seems similar to, possible regression of #8613

@hansl hansl added type: bug/fix effort1: easy (hours) command: build P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful severity5: regression labels Jan 24, 2018
@hansl hansl self-assigned this Jan 24, 2018
@hansl hansl removed their assignment Feb 1, 2018
@clydin
Copy link
Member

clydin commented Feb 7, 2018

@trendzetter Are you still experiencing this issue with 1.6.7?

@trendzetter
Copy link
Author

trendzetter commented Feb 14, 2018

~~Issue no longer present in 1.6.8.~~~

I did not test correctly. The "allowOutsideOutDir" configuration was not present in the .angular-cli.json.
The issue is not resolved.

@yuvalbl
Copy link

yuvalbl commented Apr 23, 2018

Angular version: 6.0.0-rc.5
Angular-CLI version: 6.0.0-rc.5

I've created a new project and was able to build to a directory outside the project root, with no allowOutsideOutDir flag

side-note:
If I get it correctly, .angular-cli.json configuration is now included in angular.json.

Repro steps:

  1. create new project.
  2. in angular.json change outputPath to: '../MyDir'
  3. run ng build
  4. see build output outside the project root directory

Related to #9686
seems like this commit is the problem

@filipesilva
Copy link
Contributor

This option has been removed in Angular CLI 6. I now added a Breaking Changes section to https://github.com/angular/angular-cli/releases/tag/v6.0.0, with this change listed, will also add a warning during the update process. This is being tracked in #10647.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort1: easy (hours) P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful severity5: regression type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants