docs(@angular/cli): Updates global library instructions #6339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumitarora
previously approved these changes
May 16, 2017
filipesilva
previously approved these changes
May 16, 2017
| ``` | ||
|
|
||
| When working with scripts that extend other libraries like may be the case with JQuery plugins |
There was a problem hiding this comment.
This sentence reads a bit weird with the may there, perhaps it should be extend other libraries, for instance with with JQuery plugins?
|
@dave11mj LGTM aside from the nit, thanks for taking the time to do this 👍 |
dave11mj
force-pushed
the
docs-global-lib-interfaces
branch
from
785a87d to
45c325e
Compare
|
No problem ~ ^^, and I agree that sentence could have used a little re-writing so I updated the commit to add the suggestion! :D |
dave11mj
force-pushed
the
docs-global-lib-interfaces
branch
from
45c325e to
709b3f9
Compare
sumitarora
approved these changes
May 17, 2017
dond2clouds
pushed a commit
to d2clouds/speedray-cli
that referenced
this pull request
Apr 23, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@filipesilva, follows up comments on #6294