Skip to content

docs: add global lib usage instructions #6294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2017

Conversation

filipesilva
Copy link
Contributor

See #6033 for context.

@dave11mj
Copy link
Contributor

dave11mj commented May 12, 2017

Would it be worth mentioning you have to add the types to tsconfig.json ? specially one like jQuery where you explicitly install them using npm install @types/jquery ... In my applications I just add jquery to tsconfig.app.json. Sneaking a links to this docs covers what I was mentioning about adding types to tsconfig after installing them. https://github.com/angular/angular-cli/blob/master/docs/documentation/stories/third-party-lib.md

Might also be worth mentioning interfacing jQuery or other libraries as a nice technique to add additional methods that are not part of the jquery core / typings installed.

@sumitarora sumitarora requested review from hansl and Brocco May 15, 2017 01:05
@sumitarora sumitarora self-assigned this May 15, 2017
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumitarora sumitarora merged commit cf2352f into angular:master May 15, 2017
sumitarora pushed a commit that referenced this pull request May 15, 2017
@filipesilva filipesilva deleted the global-lib-imports branch May 16, 2017 09:58
@filipesilva
Copy link
Contributor Author

@dave11mj that's a good point, would you be interested in making a followup PR as this one has already been merged?

@dave11mj
Copy link
Contributor

ok !

dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants