-
Notifications
You must be signed in to change notification settings - Fork 12k
Fix for #3875 #4393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #3875 #4393
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
@googlebot I signed it! |
@googlebot why won't you verify me? |
@sterfpaul Because it's after confirmation from the person that committed the first two commits, not your confirmation of signing the CLA. |
@equinox I am the commiter of all these commits and i signed the cla and i linked the email addresses from the commits to the cla. So i don't get why it's still not verifying me. |
I signed it! |
@sterfpaul Are you reopening this somewhere else? Just making sure I follow along since this one has changed PRs a couple times. This is a fix we're looking for. |
I can reopen it. But it doesn't fix the problem i was having which is why I closed it. Did you test if this fixes your problem and could you describe your problem? Then I can reopen it. |
Ours is an issue with using Hadn't tested this solution locally yet though, we were waiting on it getting merged. |
Yeah I was waiting on that too. Then I cloned it myself and tested it but it doesn't work. I did find a workaround that might work for you. Partial workaround for the problem in my repo is to add the following paths configuration to tsconfig.json:
Doesn't seem to work for everything. Not for Observable from rxjs for example. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The problem: duplication of symlinked source files (npm linked sources) in CompilerHost's stats.
The solution: resolve these paths before of all
Gift of jdavidls
Exact same as: #3877 but with a new master.
(I remade this because Travis CI build was failing see: #4354)