Skip to content

Update compiler_host.ts (Fix for #3847) #3877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

jdavidls
Copy link

@jdavidls jdavidls commented Jan 6, 2017

The problem: duplication of symlinked source files (npm linked sources) in CompilerHost's stats.
The solution: resolve these paths before of all

It's my gift of kings :)

Fix #3847

Fix for angular#3875 
The problem: duplication of symlinked source files (npm linked sources) in CompilerHost's stats.
The solution: resolve these paths before of all
Gift of kings
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@jdavidls jdavidls changed the title Update compiler_host.ts (Fix for #3875) Update compiler_host.ts (Fix for #3847) Jan 6, 2017
@timofeysie
Copy link

What is the status of this PR? I am getting this error when trying to use an npm link lib in my Ionic 2 project:

undefined is not a constructor (evaluating 'new __WEBPACK_IMPORTED_MODULE_8_shared_lib__

Will this PR fix the issue?

@jdavidls
Copy link
Author

Hi @timofeysie.

This PR fix the building errors described in #3847 (I made a mistake by labeling #3875),
Where npm linked libraries with same dependencies are duplicated, It's solves the «Type 'XXX' is not assignable to type 'XXX» compilation errors, where XXX are the same type declares in the same source file, but resolved by different symlink.

The only thing that does this PR is to resolve all the symlinked source files before to passing them to the compiler.

The issue you are describing seems to be something different.

Sorry, i'm a disinterested contributor, i think that I can not help you much.

@filipesilva filipesilva requested a review from hansl January 24, 2017 13:04
@filipesilva
Copy link
Contributor

@hansl can you review?

@Bbbrinks
Copy link

Bbbrinks commented Feb 2, 2017

Any update on this? Is there any way I could help to fix the failing checks?

@BernhardRode
Copy link

@sterfpaul the whole file got refactored/moved ... i tried to find the place, where this could fit, too... but had no luck....

@Bbbrinks
Copy link

Bbbrinks commented Feb 2, 2017

@BernhardRode Seems about the same to me on current master.

This was referenced Feb 2, 2017
@filipesilva
Copy link
Contributor

Closing as something similar has already been added.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fail when using npm link to some libraries
7 participants