-
Notifications
You must be signed in to change notification settings - Fork 12k
Update compiler_host.ts (Fix for #3847) #3877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix for angular#3875 The problem: duplication of symlinked source files (npm linked sources) in CompilerHost's stats. The solution: resolve these paths before of all Gift of kings
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
What is the status of this PR? I am getting this error when trying to use an npm link lib in my Ionic 2 project:
Will this PR fix the issue? |
Hi @timofeysie. This PR fix the building errors described in #3847 (I made a mistake by labeling #3875), The only thing that does this PR is to resolve all the symlinked source files before to passing them to the compiler. The issue you are describing seems to be something different. Sorry, i'm a disinterested contributor, i think that I can not help you much. |
@hansl can you review? |
Any update on this? Is there any way I could help to fix the failing checks? |
@sterfpaul the whole file got refactored/moved ... i tried to find the place, where this could fit, too... but had no luck.... |
@BernhardRode Seems about the same to me on current master. |
Closing as something similar has already been added. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The problem: duplication of symlinked source files (npm linked sources) in CompilerHost's stats.
The solution: resolve these paths before of all
It's my gift of kings :)
Fix #3847