css preprocessor plugins #388
Conversation
|
|
||
| options = options || {}; | ||
| Plugin.call(this, inputNodes, { | ||
| cacheInclude: [/(.*?).scss$/, /(.*?).sass$/] |
There was a problem hiding this comment.
Shouldn't it be \.scss and \.sass ?
There was a problem hiding this comment.
And the ? isn't necessary afaict.
|
Updated, thanks for checking @gkalpak. |
| it('Installs sass support successfully via `ng install sass`', function() { | ||
| this.timeout(420000); | ||
|
|
||
| sh.exec('npm install node-sass', { silent: true }); |
There was a problem hiding this comment.
I'm not familiar with the project's conventions, but should this be ng install sass ?
(If not, the test description is kind of inaccurate.)
There was a problem hiding this comment.
Hi @gkalpak. I need to update the description, you are right. We abandoned the ng install command for now.
There was a problem hiding this comment.
@jkuri, I didn't know about ng install 😃
I try to follow along, but you are moving too fast 👍
jkuri
force-pushed
the
css-support
branch
2 times, most recently
from
bbd9a14 to
3fa1f6f
Compare
|
|
||
| return new CompassPlugin([compassSrcTree]); | ||
| } else { | ||
| return; |
jkuri
force-pushed
the
css-support
branch
2 times, most recently
from
66545d6 to
19a1762
Compare
| sass = require('sass'); | ||
| compass = require('compass'); | ||
| } catch (e) { | ||
| sass = require(`${process.env.PROJECT_ROOT}/node_modules/node-sass`); |
There was a problem hiding this comment.
If ${process.env.PROJECT_ROOT}/node_modules/node-sass exists, wouldn't require('sass') have picked it up ?
There was a problem hiding this comment.
You cannot require peer dependencies without having a peerDependency key in package.json. We could put it there as optional. We need to experiment on this.
|
|
||
| compile(fileName, inputPath, outputPath) { | ||
| let sassOptions = { | ||
| file: path.join(fileName), |
|
I'm not familiar with compass tbh, but I wonder what happens if both |
|
If you have both installed, one of them will take precendence. If you have a custom workflow you should have a custom broccoli configuration anyway. @jkuri LGTM. |
|
Thanks Hans. |
|
But if |
|
@gkalpak I am fixing that. |
jkuri
force-pushed
the
css-support
branch
2 times, most recently
from
21ce9c9 to
3501010
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.