feat(install): 1. and 3. phase from design docs

[jkuri]

Install example: ng install moment --typings moment-node
Uninstall examle: ng uninstall lodash --typings lodash

[cironunes]

no tests? :)

[jkuri]

Not yet :-)

[hansl]

The goal of promises was to avoid this kind of thing :) you can simplify this like this:

    return that.removeFromPackageJSON(that.package)
      .then(() => that.npmUninstall(that.package))
      .then(() => that.unlinkPackage(that.package))
      .then(() => that.removeFromSystemJSConfig(that.package))
      .then(() => {
        that.ui.stopProgress();
        if (that.typings) {
          that.ui.startProgress(chalk.green('Uninstalling typings:', chalk.yellow(that.typings)), chalk.green('.'));
          return that.typingsUninstall(that.typings)
        }
      })
      .then(() => {
        that.ui.stopProgress();
        that.announceOKCompletion();
      });

This uses both the fact that the arrow function returns the value if you don't put it in a block, and that a promise executor returns a promise.

[jkuri]

thanks Ciro.

[hansl]

This seems unused.

[hansl]

Could you use System.config(...) here directly?

[jkuri]

Sure, its nicer. Done.

[hansl]

Why do we want to ignore that single file? It seems like it should be linted.

[jkuri]

Because of the double quotes which are mandatory for JSON.parse in systemjs-helper.ts.

[hansl]

This sounds more like a map() than a forEach().

[hansl]

You don't need that, just return Promise.all(...).then(...). then() returns a Promise.

[jkuri]

Thanks, updated.

[hansl]

You can do something like this to simplify:

    compile(fileName, inputPath, outputPath) {
      let content = fs.readFileSync(fileName, 'utf8');

      return less.render(content)
        .then(output => {
          let filePath = fileName.replace(inputPath, outputPath).replace(/\.less$/, '.css');
          fse.outputFileSync(filePath, output.css, 'utf8');
        });
    }

please do that for all compile() functions :)

[jkuri]

Fixed.

[jkuri]

Closing this. If nothing else, I learned something from this PR :-) Thanks @hansl!

[choeller]

@jkuri Do I understand it correct, that this did not make it into the master? And if so - why?! 😳 I think this a super essential feature and many people are looking forward to it...

[jkuri]

We had some problems with typings. This will be implemented but cannot tell you when because I don't know it myself :) If you are interested for sass/less support you can follow it here, the rest of the things from design docs will follow later.

[choeller]

Oh, ok - that's sad to hear :/ so to use 3rd party libraries like ngrx we still need to copy the sources to the project?

[jkuri]

Unfortunately yes

[hansl]

I just want to clarify that you don't need to copy files to your project
for ngrx. You should simply be able to npm install ngrx and add those
files to your vendorNpmFiles.

We are working on the production build story to use CDN versions of those
vendor files.

On Mon, Apr 4, 2016 at 10:41 AM, Jan Kuri [email protected] wrote:

Unfortunately yes

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#294 (comment)

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}