fix(generate): fix style and template url references #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,7 +14,9 @@ module.exports = { | |||
|
|
|||
| locals: function(options) { | |||
| return { | |||
| dynamicPath: this.dynamicPath.dir | |||
| dynamicPath: this.dynamicPath.dir === path.sep | |||
There was a problem hiding this comment.
this sounds like a path.resolve(this.dynamicPath.dir) or something like that, no?
|
Please add a test for this. |
Brocco
force-pushed
the
dynamic-path-ref
branch
2 times, most recently
from
78e7374 to
fbe6cba
Compare
| @@ -1,5 +1,6 @@ | |||
| var stringUtils = require('ember-cli/lib/utilities/string'); | |||
| var dynamicPathParser = require('../../utilities/dynamic-path-parser'); | |||
| var path = require('path'); | |||
|
2 nits, but LGTM. Stamping this. Good work! :) |
Dynamic paths for components were incorrectly generating paths for templates and styles Fixes angular#340
Brocco
force-pushed
the
dynamic-path-ref
branch
from
fbe6cba to
5ee4f2b
Compare
|
Thanks @hansl nits have been handled/updated |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic paths for components were incorrectly generating paths for templates and styles
Fixes #340