Skip to content

fix(generate/component): generated templateUrl and styleUrls paths are broken #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0x-r4bbit opened this issue Mar 23, 2016 · 5 comments · Fixed by #341
Closed

fix(generate/component): generated templateUrl and styleUrls paths are broken #340

0x-r4bbit opened this issue Mar 23, 2016 · 5 comments · Fixed by #341

Comments

@0x-r4bbit
Copy link

Starting off with a fresh new A2 app using

$ ng new my-app

And creating a component using

$ ng g component test

Scaffolds the component fine in src/app/test however, templateUrl and styleUrls look like this:

templateUrl: 'app///test/test.html',
styleUrls: ['app///test/test.css']

angular-cli version: 0.0.26
node version: 4.3.2

@Brocco
Copy link
Contributor

Brocco commented Mar 23, 2016

The dynamic path feature has broken this, I will have a PR pushed up soon to fix this

@0x-r4bbit
Copy link
Author

Awesome @Brocco thank you!

Brocco added a commit to Brocco/angular-cli that referenced this issue Mar 23, 2016
Dynamic paths for components were incorrectly generating paths for templates and styles
Fixes angular#340
Brocco added a commit to Brocco/angular-cli that referenced this issue Mar 23, 2016
Dynamic paths for components were incorrectly generating paths for templates and styles
Fixes angular#340
Brocco added a commit to Brocco/angular-cli that referenced this issue Mar 23, 2016
Dynamic paths for components were incorrectly generating paths for templates and styles
Fixes angular#340
Brocco added a commit to Brocco/angular-cli that referenced this issue Mar 23, 2016
Dynamic paths for components were incorrectly generating paths for templates and styles
Fixes angular#340
@0x-r4bbit
Copy link
Author

This issue is still present with angular-cli version 0.0.29

/cc @hansl @Brocco

@jkuri jkuri reopened this Apr 6, 2016
@jkuri
Copy link
Contributor

jkuri commented Apr 6, 2016

Closing as it is resolved now on master.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants