Skip to content

fix(@angular-devkit/build-angular): emit root files when localize is enabled when using the esbuild based builders #26392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

alan-agius4
Copy link
Collaborator

This commit adds back the root files to the outputFiles when localize is enabled.

Closes #26386

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Nov 17, 2023
@alan-agius4 alan-agius4 requested a review from clydin November 17, 2023 11:25
…s enabled when using the esbuild based builders

This commit adds back the root files to the `outputFiles` when localize is enabled.

Closes angular#26386
@clydin clydin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 17, 2023
@alan-agius4 alan-agius4 merged commit aa13140 into angular:main Nov 17, 2023
@alan-agius4 alan-agius4 deleted the root-files-localize branch November 17, 2023 13:07
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

application build does not generate 3rdpartylicenses.txt when building localized app
2 participants