Skip to content

application build does not generate 3rdpartylicenses.txt when building localized app #26386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
acohenOT opened this issue Nov 17, 2023 · 1 comment · Fixed by #26392
Closed
1 task done

Comments

@acohenOT
Copy link
Contributor

Command

build

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

16

Description

When building a new Angular 17 app using the default application builder and using --localize, 3rdpartylicenses.txt is not generated. Without --localize, the file is present.

Minimal Reproduction

ng new test-app --defaults
cd test-app
ng add @angular/localize
ng build --localize

examine dist/test-app
the new browser directory is present, but no 3rdpartylicenses.txt file.

Exception or Error

No response

Your Environment

Angular CLI: 17.0.1
Node: 20.9.0
Package Manager: npm 10.2.4
OS: win32 x64

Angular: 17.0.3
... animations, common, compiler, compiler-cli, core, forms
... localize, platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1700.1
@angular-devkit/build-angular   17.0.1
@angular-devkit/core            17.0.1
@angular-devkit/schematics      17.0.1
@angular/cli                    17.0.1
@schematics/angular             17.0.1
rxjs                            7.8.1
typescript                      5.2.2
zone.js                         0.14.2

Anything else relevant?

No response

alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Nov 17, 2023
…s enabled when using the esbuild based builders

This commit adds back the root files to the `outputFiles` when localize is enabled.

Closes angular#26386
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Nov 17, 2023
…s enabled when using the esbuild based builders

This commit adds back the root files to the `outputFiles` when localize is enabled.

Closes angular#26386
alan-agius4 added a commit that referenced this issue Nov 17, 2023
…s enabled when using the esbuild based builders

This commit adds back the root files to the `outputFiles` when localize is enabled.

Closes #26386
alan-agius4 added a commit that referenced this issue Nov 17, 2023
…s enabled when using the esbuild based builders

This commit adds back the root files to the `outputFiles` when localize is enabled.

Closes #26386

(cherry picked from commit aa13140)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants