fix(@angular/cli): temporarily handle boolean options in schema prefixed with no
#23405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: patch
alan-agius4
added
the
action: review
alan-agius4
force-pushed
the
no-options-schema
branch
from
b3ec2bd to
0dfa17b
Compare
clydin
approved these changes
Jun 21, 2022
alan-agius4
changed the title
nono
…xed with `no` With this commit we introduce an interim solution for options prefixed with `no` in `schema.json` Previously, such options were handled as normal boolean option, but yargs handles options prefixed with `no` as negatations of the original option. Example with yargs, an option `noWatch` is will registered as `watch`. Closes angular#23397
alan-agius4
force-pushed
the
no-options-schema
branch
from
0dfa17b to
4f93dab
Compare
alan-agius4
added
action: merge
|
🙂 👍 👍 👍 👍 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we introduce an interim solution for options prefixed with
noinschema.jsonPreviously, such options were handled as normal boolean option, but yargs handles options prefixed with
noas negatations of the original option. Example with yargs, an optionnoWatchis will registered aswatch.Closes #23397