Regression on command line arguments parser

[JohannesHoppe]

🐞 Bug report

Command (mark with an x)

• new
• build
• serve
• test
• e2e
• generate
• add
• update
• lint
• extract-i18n
• run
• config
• help
• version
• doc

Is this a regression?

This worked in v13 of the CLI

Description

We are working on updating our ng deploy schematic for Angular 14, unfortunately some command line arguments are no longer detected correctly. Arguments like noBuild, noSilent, noDotFiles no longer work, but buildTarget and dryRun do. I assume this is related with #22778 and the fact that Yargs supports --no-flags. In the past, the word no had no meaning, now it has one: https://github.com/yargs/yargs/blob/main/docs/tricks.md#negate

In Angular 13 i was able write no-build as an argument and it was used as it-is, but now this is interpreted as the negation of build – which is an unknown argument. This breaks a couple of builders that all share some code/ideas and use the same argument called no-build.

• @netlify-builder/deploy
• angular-cli-ghpages
• as well as ngx-deploy-docker, ngx-deploy-npm, and ngx-deploy-ftp
• there could be more...

🔬 Minimal Reproduction

Please follow our README for contributors, which is essentially:

1. Clone the project

   git clone https://github.com/angular-schule/angular-cli-ghpages.git
   cd angular-cli-ghpages

2. Install the dependencies

   cd src
   npm install

3. Build the project:

   npm run build

4. Create a local npm link:

   cd dist
   npm link

5. Go to a new folder and create a fresh angular project:

   ng new test
   cd test

6. Add the local version of angular-cli-ghpages.

   npm link angular-cli-ghpages

7. Now execute the ng-add schematic.

   ng add angular-cli-ghpages

8. This will work, but will complain about a missing git configuration (which is fine here)

   ng deploy
   ng deploy --dry-run

9. But this will NOT work, same for all other arguments with a "no" in the name

   ng deploy --no-build

🔥 Exception or Error

ng deploy --no-build
Error: Unknown argument: build

🌍 Your Environment

Angular CLI: 14.0.2
Node: 16.15.1
Package Manager: npm 8.11.0
OS: darwin arm64

Angular: 14.0.2
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1400.2
@angular-devkit/build-angular   14.0.2
@angular-devkit/core            14.0.2
@angular-devkit/schematics      14.0.2
@schematics/angular             14.0.2
rxjs                            7.5.5
typescript                      4.7.4

[alan-agius4]

Negation was always possible with boolean options even prior to version 14. This can also be seen in older versions of the docs https://v8.angular.io/cli#boolean-and-enumerated-options

In this case, the option was named noBuild and while it worked previously, the semantics of this seemed to be flawed as this option could also be negated --no-no-build.

The correct to define that option would be

"build": {
  "type": "boolean",
  "default": true,
  "description": "Build process during deployment."
 }

We could add a middleware to handle options which are defined with no. This would need some further discussions with the team to discuss if we'd want to issue a warning when using this behaviour.

[JohannesHoppe]

From my point of view, this is a breaking change. Therefore, I would be happy if the old behaviour would be restored and a warning would be displayed. For the next version of Angular you could then drop this workaround.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}