Skip to content

fix(pipes): camelized pipe name #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2016
Merged

fix(pipes): camelized pipe name #225

merged 1 commit into from
Feb 19, 2016
+1 −1

Conversation

cexbrayat
Copy link
Member

Fixes #224

BREAKING CHANGES

Before:

@Pipe({
  name: 'FromNow'
})

After:

@Pipe({
  name: 'fromNow'
})

@cexbrayat
fix(pipes): camelized pipe name
ba9ad66 
Fixes angular#224

BREAKING CHANGES

Before:
```
@pipe({
  name: 'FromNow'
})
```

After:
```
@pipe({
  name: 'fromNow'
})
```
@filipesilva
Copy link
Contributor

Looks good to me 👍

@cironunes cironunes merged commit ba9ad66 into angular:master Feb 19, 2016
@cexbrayat cexbrayat deleted the fix/pipes-in-lowercase branch February 19, 2016 13:51
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipe name should be in lowercase
3 participants
@cexbrayat @filipesilva @cironunes