Skip to content

Pipe name should be in lowercase #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cexbrayat opened this issue Feb 19, 2016 · 1 comment · Fixed by #225
Closed

Pipe name should be in lowercase #224

cexbrayat opened this issue Feb 19, 2016 · 1 comment · Fixed by #225

Comments

@cexbrayat
Copy link
Member

A generated pipe ends up with a name starting with an uppercase, whereas the usual convention AFAIK is to have a name starting with a lowercase:

Actual:

@Pipe({
  name: 'FromNow'
})

Expected:

@Pipe({
  name: 'fromNow'
})
cexbrayat added a commit to cexbrayat/angular-cli that referenced this issue Feb 19, 2016
@cexbrayat
fix(pipes): camelized pipe name
e03dfa2 
Fixes angular#224
cexbrayat added a commit to cexbrayat/angular-cli that referenced this issue Feb 19, 2016
@cexbrayat
fix(pipes): camelized pipe name
ba9ad66 
Fixes angular#224

BREAKING CHANGES

Before:
```
@pipe({
  name: 'FromNow'
})
```

After:
```
@pipe({
  name: 'fromNow'
})
```
@cexbrayat cexbrayat mentioned this issue Feb 19, 2016
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(pipes): camelized pipe name cexbrayat/angular-cli
1 participant
@cexbrayat