fix(tests): link package in e2e tests

[filipesilva]

Close #194

This issue proved to be harder to fix than it initially looked like.

Running npm link did not seem to work, due to npm itself being local as per the npm link npm command in .travis.yml.

Removing npm link npm caused the tests to file in a spectacular fashion.

npm4 builds fail because ng install tests report a missing package - npm itself. This seems to have been what originated the inclusion of npm link npm in .travis.yml. Also related, #185 (comment).

npm5 builds fail in a much more confusing way.

Linking angular-cli shows a couple of warnings about npm packages that aren't part of angular-cli nor are present in npm4 builds:

npm WARN prefer global [email protected] should be installed with -g
npm WARN prefer global [email protected] should be installed with -g

There is also a weird stray error during the ng new test, that seems to be responsible for for ng new failing:

Error: ENOENT: no such file or directory, open '/home/travis/build/angular/angular-cli/tmp/foo/package.json'
    at Error (native)

The e2e build tests fail with missing core packages that should have been installed in in the initial ng new test-project (that seems to fail):

  app.ts (1, 25): Cannot find module 'angular2/platform/browser'.
  app.ts (3, 32): Cannot find module 'angular2/router'.
  app/test-project.spec.ts (1, 65): Cannot find module 'angular2/testing'.
  app/test-project.ts (1, 25): Cannot find module 'angular2/core'.
  app/test-project.ts (2, 46): Cannot find module 'angular2/router'.

I tried removing the acceptance tests for ng install and ng uninstall and the resulting build seems to pass every test, correctly linking the existing angular-cli and succeding and bulding the generated project, typings included.

This seems to indicate that either the ng install and ng uninstall acceptance tests or the commands themselves break subsequent tests.

I found two references to the instability of using the npm module programatically: one on stack overflow and one on ember-cli.

This prompted me to change the ng install and ng uninstall code to use shelljs to run npm install/uninstall commands instead using npm programatically as before. That seems to have fixed the weird interactions between their acceptance tests and the e2e tests.

/cc @hansl @jkuri @Brocco

[Brocco]

lgtm

[hansl]

This is a pattern that we will do a lot and I'd like to avoid the copy and paste. Could you move the sh.exec and promise into a helper function that would be imported everywhere?

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}