Skip to content

docs: update testing chapter with general test commands #18714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

Jefiozie
Copy link
Contributor

@Jefiozie Jefiozie commented Sep 7, 2020

Updated the information around testing as discussed in #18710

Closes: #18710

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change needs to be done in the readme template https://github.com/angular/angular-cli/blob/master/scripts/templates/readme.ejs

Afterwards you need to run yarn admin templates to generate the MD file.

@Jefiozie
Copy link
Contributor Author

Jefiozie commented Sep 7, 2020

Sorry, I didn't know this will apply these changes.

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

A couple of small comments above.

@Jefiozie
Copy link
Contributor Author

Jefiozie commented Sep 8, 2020

I've made the requested changes let me know if I need to make more changes.

@Jefiozie Jefiozie requested a review from alan-agius4 September 8, 2020 07:15
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Sep 8, 2020
@alan-agius4 alan-agius4 merged commit b2f0f07 into angular:master Sep 8, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 9, 2020
@Jefiozie Jefiozie deleted the fix_testing_readme branch October 27, 2024 08:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect/ missing contribution information in README
3 participants