Incorrect/ missing contribution information in README

[Jefiozie]

Hi there,

I was looking to contribute to #17579 I've started reading the README file to see what the correct steps where for contribution and other information. While reading it looks to me that the is missing or incorrect information in the testing chapter of the README file. It looks like there have been changes around the test and these steps are not valid anymore.

In older versions, the test script run node ./bin/devkit-admin test, is this still the approach we should take?

Thanks.

PS I hope this is the correct issue template for these kinds of issues.

[alan-agius4]

Hi there,

You are correct the readme is outdated.

To test a single package

yarn bazel test //packages/schematics/update:update_test
yarn bazel test //packages/schematics/angular:no_typescript_runtime_dep_test
yarn bazel test //packages/schematics/angular:angular_test
yarn bazel test //packages/ngtools/webpack:webpack_test
yarn bazel test //packages/angular_devkit/schematics_cli:schematics_cli_test
yarn bazel test //packages/angular_devkit/schematics/tools:tools_test
yarn bazel test //packages/angular_devkit/schematics/tasks:tasks_test
yarn bazel test //packages/angular_devkit/schematics:schematics_test
yarn bazel test //packages/angular_devkit/core/node:node_test
yarn bazel test //packages/angular_devkit/core:core_test
yarn bazel test //packages/angular_devkit/build_webpack:build_webpack_test
yarn bazel test //packages/angular_devkit/build_optimizer:build_optimizer_test
yarn bazel test //packages/angular_devkit/build_ng_packagr:build_ng_packagr_ve_test
yarn bazel test //packages/angular_devkit/build_ng_packagr:build_ng_packagr_test
yarn bazel test //packages/angular_devkit/build_angular:build_angular_tslint_test
yarn bazel test //packages/angular_devkit/build_angular:build_angular_test
yarn bazel test //packages/angular_devkit/build_angular:build_angular_server_test
yarn bazel test //packages/angular_devkit/build_angular:build_angular_protractor_test
yarn bazel test //packages/angular_devkit/build_angular:build_angular_ng-packagr_test
yarn bazel test //packages/angular_devkit/build_angular:build_angular_karma_test
yarn bazel test //packages/angular_devkit/build_angular:build_angular_extract-i18n_test
yarn bazel test //packages/angular_devkit/build_angular:build_angular_dev-server_test
yarn bazel test //packages/angular_devkit/build_angular:build_angular_browser_ve_test
yarn bazel test //packages/angular_devkit/build_angular:build_angular_browser_test
yarn bazel test //packages/angular_devkit/build_angular:build_angular_app-shell_test
yarn bazel test //packages/angular_devkit/benchmark:benchmark_test
yarn bazel test //packages/angular_devkit/architect:architect_test
yarn bazel test //packages/angular/pwa:pwa_test
yarn bazel test //packages/angular/cli:angular-cli_test

Test all packages
yarn bazel test packages/...

[Jefiozie]

Thanks for the quick response should I update the README?

[alan-agius4]

A PR would be awesome 😁.

\I'd suggest thought that we don't add all the test targets in the read me since these change overtime.

I'd suggest to add an example, something along:

To test a single package use the full Bazel target example:

yarn bazel test //packages/schematics/angular:angular_test

For a a complete list of test targets use the below Bazel query:

yarn bazel query "tests(//packages/...)"

Also it would be great to add a note along:

You can find more info about debugging tests with Bazel in the docs.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}