Remove typings.d.ts #1604 #1615
Conversation
|
@hansl can you review if this is what you wanted? |
| @@ -14,6 +14,14 @@ import 'zone.js/dist/sync-test'; | |||
| // Unfortunately there's no typing for the `__karma__` variable. Just declare it as any. | |||
| declare var __karma__: any; | |||
|
|
|||
| // Typings reference file, see links for more information | |||
There was a problem hiding this comment.
These comments are useless. Please provide a comment that explains why we need those declaration here.
|
The tests are broken by this change. Is there anything else that needs those typings? There shouldn't. |
|
Related issue: #1604 |
|
Thanks, @filipesilva, I forgot about that one. I'm not entirely sure how to approach this now, but having |
|
The tests are passing, but I actually see a lot of errors on the log itself: https://travis-ci.org/angular/angular-cli/jobs/152746267#L2320. This is the error we were expecting when converting template imports via https://github.com/TheLarkInn/angular2-template-loader. More importantly though, @TheLarkInn it seems that |
|
Outdated a new PR is being submitted to update this file, but it is needed to reference System and to be available to specify other typings files for global libraries. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.