Skip to content

Remove typings.d.ts #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hansl opened this issue Aug 8, 2016 · 6 comments
Closed

Remove typings.d.ts #1604

hansl opened this issue Aug 8, 2016 · 6 comments

Comments

@hansl
Copy link
Contributor

hansl commented Aug 8, 2016

Its content is only needed for test, so let's move those declaration in test.ts.

mcabreradev added a commit to mcabreradev/angular-cli that referenced this issue Aug 9, 2016
@TheLarkInn
Copy link
Member

Can we still keep the require() which is needed for the angular2-template-loader to be ambiently defined. Or is this just in regards to the System, and moduledefinitions.

@hansl
Copy link
Contributor Author

hansl commented Aug 10, 2016

Do you run angular2-template-loader before the typescript compilation?

@TheLarkInn
Copy link
Member

Yes it does, it modifies the ts file prior to.

@mbeckenbach
Copy link

Are you sure, that you want to remove it? There are still sometimes cases where you have to manually write some definitions for external libraries that don't have one

@filipesilva
Copy link
Contributor

Fixed by #2714. Didn't remove the file but updated the comments.

https://github.com/angular/angular-cli#3rd-party-library-installation also references this file for typeless libs.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants