Skip to content

fix(@angular/cli): only show add/update package install output on errors #16041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented Nov 2, 2019

Closes #16014
Closes #16027

@clydin clydin added the target: patch This PR is targeted for the next patch release label Nov 2, 2019
@clydin clydin requested a review from alan-agius4 November 2, 2019 02:17
@alan-agius4
Copy link
Collaborator

Nit: probably makes also sense to have a status indicator as per #15940

@clydin
Copy link
Member Author

clydin commented Nov 3, 2019

I'd like to do a larger refactor in the 9.x timeframe that combines the two so that there are not two different package install methods in the system.
Since this PR needs to go in 8.3.x, I think the changes should be kept minimal for now especially considering that (unlike during the actual update) only a single package is installed and 8.x does not have the ngcc post-install.

@vikerman vikerman added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Nov 4, 2019
@vikerman
Copy link
Contributor

vikerman commented Nov 4, 2019

Needs rebase

@clydin clydin removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews PR target: LTS-only labels Nov 5, 2019
@vikerman vikerman merged commit 84ba5d5 into angular:master Nov 6, 2019
@clydin clydin deleted the noisy-installs branch November 6, 2019 00:38
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
4 participants