fix(@angular-devkit/schematics): hide install output by default #15940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
added
the
target: major
filipesilva
force-pushed
the
update-hide-output
branch
from
b6a0add to
1422925
Compare
alan-agius4
reviewed
Oct 28, 2019
| obs.next(); | ||
| obs.complete(); | ||
| } else { | ||
| if (!!options.hideOutput) { |
There was a problem hiding this comment.
Nit: !! is redundant.
alan-agius4
reviewed
Oct 28, 2019
| const message = 'Package install failed, see above.'; | ||
| obs.error(new Error(message)); | ||
| } | ||
| }); | ||
| if (!!options.hideOutput) { |
There was a problem hiding this comment.
Nit: !! is redundant.
alan-agius4
reviewed
Oct 28, 2019
filipesilva
commented
Oct 28, 2019
| @@ -100,16 +99,29 @@ export default function( | |||
| } | |||
|
|
|||
| return new Observable(obs => { | |||
| spawn(taskPackageManagerName, args, spawnOptions) | |||
| // tslint:disable-next-line: no-console | |||
| console.log('Installing packages...'); | |||
There was a problem hiding this comment.
@vikerman suggested we add some measure of showing progress.
filipesilva
force-pushed
the
update-hide-output
branch
from
1422925 to
fba3098
Compare
filipesilva
force-pushed
the
update-hide-output
branch
from
fba3098 to
b8447f1
Compare
Current output:
```
kamik@RED-X1C6 MINGW64 /d/sandbox/latest-app (master)
$ ng update @angular/cli --next --force
Using package manager: 'yarn'
Collecting installed dependencies...
Found 30 dependencies.
Fetching dependency metadata from registry...
Package "@angular-devkit/build-angular" has a missing peer dependency of "@angular/localize" @ "^9.0.0-next.11".
Updating package.json with dependency @angular/cli @ "9.0.0-next.15" (was "9.0.0-next.14")...
Updating package.json with dependency @angular-devkit/build-angular @ "0.900.0-next.15" (was "0.900.0-next.14")...
Updating package.json with dependency typescript @ "3.6.4" (was "3.5.3")...
UPDATE package.json (1353 bytes)
warning @angular-devkit/[email protected]: The engine "pnpm" appears to be invalid.
warning @angular-devkit/[email protected]: The engine "pnpm" appears to be invalid.
warning @ngtools/[email protected]: The engine "pnpm" appears to be invalid.
warning @angular-devkit/[email protected]: The engine "pnpm" appears to be invalid.
warning @angular-devkit/[email protected]: The engine "pnpm" appears to be invalid.
warning @angular-devkit/[email protected]: The engine "pnpm" appears to be invalid.
warning @angular/[email protected]: The engine "pnpm" appears to be invalid.
warning @schematics/[email protected]: The engine "pnpm" appears to be invalid.
warning @angular-devkit/[email protected]: The engine "pnpm" appears to be invalid.
warning @schematics/[email protected]: The engine "pnpm" appears to be invalid.
Compiling @angular/animations : es2015 as esm2015
Compiling @angular/compiler/testing : es2015 as esm2015
Compiling @angular/core : es2015 as esm2015
Compiling @angular/common : es2015 as esm2015
Compiling @angular/animations/browser : es2015 as esm2015
Compiling @angular/animations/browser/testing : es2015 as esm2015
Compiling @angular/core/testing : es2015 as esm2015
Compiling @angular/platform-browser : es2015 as esm2015
Compiling @angular/common/testing : es2015 as esm2015
Compiling @angular/platform-browser/testing : es2015 as esm2015
Compiling @angular/platform-browser/animations : es2015 as esm2015
Compiling @angular/common/http : es2015 as esm2015
Compiling @angular/router : es2015 as esm2015
Compiling @angular/forms : es2015 as esm2015
Compiling @angular/platform-browser-dynamic : es2015 as esm2015
Compiling @angular/common/http/testing : es2015 as esm2015
Compiling @angular/router/testing : es2015 as esm2015
Compiling @angular/platform-browser-dynamic/testing : es2015 as esm2015
```
New success output:
```
kamik@RED-X1C6 MINGW64 /d/sandbox/latest-app (master)
$ ng update @angular/cli --next --force
Using package manager: 'yarn'
Collecting installed dependencies...
Found 30 dependencies.
Fetching dependency metadata from registry...
Package "@angular-devkit/build-angular" has a missing peer dependency of "@angular/localize" @ "^9.0.0-next.11".
Updating package.json with dependency @angular/cli @ "9.0.0-next.15" (was "9.0.0-next.14")...
Updating package.json with dependency @angular-devkit/build-angular @ "0.900.0-next.15" (was "0.900.0-next.14")...
Updating package.json with dependency typescript @ "3.6.4" (was "3.5.3")...
UPDATE package.json (1353 bytes)
Installing packages...
Packages installed successfully.
```
New error output:
```
kamik@RED-X1C6 MINGW64 /d/sandbox/latest-app (master)
$ ng update @angular/cli --next --force
Using package manager: 'yarn'
Collecting installed dependencies...
Found 30 dependencies.
Fetching dependency metadata from registry...
Package "@angular-devkit/build-angular" has a missing peer dependency of "@angular/localize" @ "^9.0.0-next.11".
Updating package.json with dependency @angular/cli @ "9.0.0-next.15" (was "9.0.0-next.14")...
Updating package.json with dependency @angular-devkit/build-angular @ "0.900.0-next.15" (was "0.900.0-next.14")...
Updating package.json with dependency typescript @ "3.6.4" (was "3.5.3")...
UPDATE package.json (1353 bytes)
Installing packages...
warning @angular-devkit/[email protected]: The engine "pnpm" appears to be invalid.
warning @angular-devkit/[email protected]: The engine "pnpm" appears to be invalid.
warning @angular-devkit/[email protected]: The engine "pnpm" appears to be invalid.
warning @ngtools/[email protected]: The engine "pnpm" appears to be invalid.
warning @angular-devkit/[email protected]: The engine "pnpm" appears to be invalid.
warning @angular-devkit/[email protected]: The engine "pnpm" appears to be invalid.
warning @angular/[email protected]: The engine "pnpm" appears to be invalid.
warning @schematics/[email protected]: The engine "pnpm" appears to be invalid.
warning @angular-devkit/[email protected]: The engine "pnpm" appears to be invalid.
warning @schematics/[email protected]: The engine "pnpm" appears to be invalid.
Compiling @angular/animations : es2015 as esm2015
Compiling @angular/compiler/testing : es2015 as esm2015
Compiling @angular/core : es2015 as esm2015
Compiling @angular/common : es2015 as esm2015
Compiling @angular/animations/browser : es2015 as esm2015
Compiling @angular/animations/browser/testing : es2015 as esm2015
Compiling @angular/core/testing : es2015 as esm2015
Compiling @angular/platform-browser : es2015 as esm2015
Compiling @angular/common/testing : es2015 as esm2015
Compiling @angular/platform-browser/testing : es2015 as esm2015
Compiling @angular/platform-browser/animations : es2015 as esm2015
Compiling @angular/common/http : es2015 as esm2015
Compiling @angular/forms : es2015 as esm2015
Compiling @angular/router : es2015 as esm2015
Compiling @angular/platform-browser-dynamic : es2015 as esm2015
Compiling @angular/common/http/testing : es2015 as esm2015
Compiling @angular/platform-browser-dynamic/testing : es2015 as esm2015
Compiling @angular/router/testing : es2015 as esm2015
Package install failed, see above.
```
filipesilva
force-pushed
the
update-hide-output
branch
3 times, most recently
from
9c7b071 to
e2cd48c
Compare
filipesilva
force-pushed
the
update-hide-output
branch
from
e2cd48c to
1d29d2d
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current output:
New success output:
New error output: