Skip to content

fix(@schematics/angular): exclusively list the files in tsconfigs #15030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2019
Merged

fix(@schematics/angular): exclusively list the files in tsconfigs #15030

merged 2 commits into from
Jul 16, 2019

Conversation

alan-agius4
Copy link
Collaborator

With the omission of includes or files in tsconfig files tsc will pick up all the files under the rootDir and make them as part of the compilation. In certain cases, redundant files will be picked up which will cause a slower compilations.

Related to: TOOL-949

@alan-agius4 alan-agius4 requested a review from filipesilva July 10, 2019 13:51
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jul 10, 2019
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very comprehensive PR, great work!

Copy link
Member

@clydin clydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should only be enabled on new Ivy projects. New VE projects can still use string-based routes and this will break them.

@filipesilva
Copy link
Contributor

Indeed they can, but it is deprecated. Ivy supports the string syntax as well currently. We decoupled the two things.

Maybe we should only do this in v9 then? Or perhaps we need to document in https://angular.io/guide/deprecations#loadchildren-string-syntax that if you want to use the string syntax you need to add the file to the files array.

@alan-agius4 alan-agius4 added the needs: discussion On the agenda for team meeting to determine next steps label Jul 11, 2019
@alan-agius4
Copy link
Collaborator Author

IMHO, I think an update to the docs should suffice.

@alan-agius4
Copy link
Collaborator Author

alan-agius4 commented Jul 11, 2019

Make this for Ivy for the time being. And make this the default in version 9.

@alan-agius4 alan-agius4 removed the needs: discussion On the agenda for team meeting to determine next steps label Jul 11, 2019
With the omission of `includes` or `files` in tsconfig files tsc will pick up all the files under the rootDir and make them as part of the compilation. In certain cases, redundant files will be picked up which will cause a slower compilations.

Related to: TOOL-949
@alan-agius4
Copy link
Collaborator Author

The VE, part might be needed if we go with #15061 (comment)

@alan-agius4 alan-agius4 requested a review from clydin July 16, 2019 17:43
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Jul 16, 2019
@mgechev mgechev merged commit 0551360 into angular:master Jul 16, 2019
@alan-agius4 alan-agius4 deleted the schematic-tsconfigs branch July 17, 2019 04:25
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants