-
Notifications
You must be signed in to change notification settings - Fork 12k
fix(@schematics/angular): exclusively list the files in tsconfigs #15030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very comprehensive PR, great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should only be enabled on new Ivy projects. New VE projects can still use string-based routes and this will break them.
Indeed they can, but it is deprecated. Ivy supports the string syntax as well currently. We decoupled the two things. Maybe we should only do this in v9 then? Or perhaps we need to document in https://angular.io/guide/deprecations#loadchildren-string-syntax that if you want to use the string syntax you need to add the file to the files array. |
IMHO, I think an update to the docs should suffice. |
Make this for Ivy for the time being. And make this the default in version 9. |
With the omission of `includes` or `files` in tsconfig files tsc will pick up all the files under the rootDir and make them as part of the compilation. In certain cases, redundant files will be picked up which will cause a slower compilations. Related to: TOOL-949
The VE, part might be needed if we go with #15061 (comment) |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
With the omission of
includes
orfiles
in tsconfig files tsc will pick up all the files under the rootDir and make them as part of the compilation. In certain cases, redundant files will be picked up which will cause a slower compilations.Related to: TOOL-949