Skip to content

Add stricter files inclusions for newly generated VE apps (V9) #15056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alan-agius4 opened this issue Jul 12, 2019 · 3 comments
Closed

Add stricter files inclusions for newly generated VE apps (V9) #15056

alan-agius4 opened this issue Jul 12, 2019 · 3 comments
Labels
area: @schematics/angular feature Issue that requests a new feature
Milestone

Comments

@alan-agius4
Copy link
Collaborator

🚀 Feature request

With this PR #15030 we introduces a stricter inclusion of files in the TS compilations for Ivy.

In version 8 we decided that we shouldn't do it for VE since this will break new VE app which will use the deprecated string based lazy loading, as users will need to add the lazy loaded modules in the list of files to include.

In version 9, we should always apply the stricter files inclusion for all newly generated projects.

Files to be updated

packages/schematics/angular/application/files/tsconfig.app.json.template
tests/angular_devkit/build_angular/hello-world-app/src/tsconfig.app.json
@alan-agius4 alan-agius4 added feature Issue that requests a new feature area: @schematics/angular labels Jul 12, 2019
@alan-agius4 alan-agius4 added this to the 9.0.x milestone Jul 12, 2019
@alan-agius4
Copy link
Collaborator Author

We should also probably enable the warning for unused files for VE that was introduction in #15061

@alan-agius4
Copy link
Collaborator Author

Addressed in #15469

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: @schematics/angular feature Issue that requests a new feature
Projects
None yet
Development

No branches or pull requests

1 participant