fix(@schematics/angular): remove indentation in component html #14817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
reviewed
Jun 18, 2019
There was a problem hiding this comment.
LGTM, can you kindly change the commit msg to
fix(@schematics/angular): remove indentation in component html
Most editors remember the indentation, even if you remove all code. This way, there is no
indentation thus there is nothing for the editor to remember and there will be no need for
a HTML lint fix.
Fixes #14816
Thank you
SamanthaAdrichem
changed the title
Most editors remember the indentation, even if you remove all code. This way, there is no indentation thus there is nothing for the editor to remember and there will be no need for a HTML lint fix. Fixes #14816
|
I don't understand why the unit test fails. The unit test does nothing with the HTML file. And it worked before i changed the commit message. https://circleci.com/gh/angular/angular-cli/65211 I haven't changed anything else. Any suggestions? |
|
@SamanthaAdrichem, it's a flake. I'll restart the CI step |
alan-agius4
added
the
target: patch
alan-agius4
approved these changes
Jun 18, 2019
alan-agius4
changed the title
|
Thanks for your contribution @SamanthaAdrichem :) |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most editors remember the indentation, even if you remove all code. This way, there is no
indentation thus there is nothing for the editor to remember and there will be no need for
a HTML lint fix.
Fixes #14816