-
Notifications
You must be signed in to change notification settings - Fork 12k
Html file without indentation #14816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Somehow it doesn't link it here correctly but there is a PR for this request |
mgechev
pushed a commit
that referenced
this issue
Jun 19, 2019
Most editors remember the indentation, even if you remove all code. This way, there is no indentation thus there is nothing for the editor to remember and there will be no need for a HTML lint fix. Fixes #14816
mgechev
pushed a commit
that referenced
this issue
Jun 19, 2019
Most editors remember the indentation, even if you remove all code. This way, there is no indentation thus there is nothing for the editor to remember and there will be no need for a HTML lint fix. Fixes #14816
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
🚀 Feature request
Command (mark with an
x
)Description
A clear and concise description of the problem or missing capability...The HTML files for angular-cli are now also generated using an indentation of two spaces.
tslint can be used to fix this for the typescript files to your own style.
the HTML template is however excluded from this.
Most editors, like PHPStorm have the feature: "On edit, use indents of the openend file" so removing it and correcting it won't fix it unless you close the file so that it no longer knows it was indented incorrectly. Or press the 'convert' button.
Since the template only contains dummy test content within a
tag, i'd suggest to remove the whitespace and indentation, which will resolve this issue for most users, for the file then does not have an active indentation. And the contents will be cleared completely afterwords anyways.
Maybe my flow of toughts is incorrect. But I do really think this will fix some issues for a lot of people.
Describe the solution you'd like
If you have a solution in mind, please describe it.Update the templates (as in pull request) to not use any indentation
Describe alternatives you've considered
Have you considered any alternative solutions or workarounds?I can disable the as-is feature of the editor, but that is not wanted.
I can overwrite the component schematic to replace the HTML contents afterwords, but still.
The text was updated successfully, but these errors were encountered: