Skip to content

feat(@angular/cli): automatically update angular builders when CLI is updated #14090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2019
Merged

feat(@angular/cli): automatically update angular builders when CLI is updated #14090

merged 1 commit into from
Apr 8, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented Apr 5, 2019

No description provided.

@clydin clydin requested a review from alexeagle April 5, 2019 18:30
alexeagle
alexeagle approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like the right behavior to me, let's get Filipe or Alan to review as well since I'm not that familiar with the mechanics still

@alexeagle alexeagle requested a review from alan-agius4 April 5, 2019 18:38
@clydin clydin added the target: major This PR is targeted for the next major release label Apr 5, 2019
@alan-agius4
Copy link
Collaborator

Can we also reference this issue?

#13581

@alexeagle alexeagle merged commit 7b7d74e into angular:master Apr 8, 2019
@clydin clydin deleted the builder-peers branch April 8, 2019 18:40
@Splaktar
Copy link
Contributor

As asked in #13942 (comment), should this change have also closed #13942?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees
No one assigned
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@clydin @alan-agius4 @Splaktar @alexeagle @googlebot