fix(@angular/cli): add packageGroup for @angular/cli #13942
Conversation
packages/angular/cli/package.json
Outdated
| "migrations": "@schematics/angular/migrations/migration-collection.json" | ||
| "migrations": "@schematics/angular/migrations/migration-collection.json", | ||
| "packageGroup": { | ||
| "@angular/cli": "0.0.0" |
There was a problem hiding this comment.
Shouldn’t this package group contain the packages to updates? Aka for the cli shouldn’t it be @angular-devkit/build-angular and @angular-devkit/ng-packagr?
There was a problem hiding this comment.
It's all done in the build.ts actually.
There was a problem hiding this comment.
I'll remove this line. it's basically useless.
| fs.writeFileSync(packageJsonPath, JSON.stringify(packageJson, null, 2) + '\n'); | ||
| } | ||
| logger.info('Setting packageGroups...'); | ||
| await _setPackageGroups(sortedPackages, logger.createChild('packageGroups')); |
There was a problem hiding this comment.
Won't this add package groups to all the dev kit packages each with all the other dev kit packages included?
Do we want that? Updating the schematics CLI for instance should probably not update the CLI proper.
There was a problem hiding this comment.
I'll change it a bit.
There was a problem hiding this comment.
Done, I added a check instead that build will add package group packages if they're in the package.json already, and added all packages that I thought were okay.
This should add ng-update support to updating packages that are published from this repo. The build script only updates package.json's ng-update packageGroup dependencies, so these should be kept up to date in the future (when new packages are created). Fixes angular#13581
|
@clydin @alan-agius4 please take another look. |
|
@clydin is this obsolete now that you made a smaller-scope change? |
|
Charles took it over |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This should add ng-update support to updating ALL the packages that are published from this repo.
Fixes #13581