Skip to content

fix(@schematics/angular): use correct file extension for SASS (.scss) #13602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

akehir
Copy link

@akehir akehir commented Feb 6, 2019

The ng new command sets the incorrect file extension for SASS files in the angular.json. The configuration expects styles.sass, whereas it should be styles.scss. This is due to the fact that the pull request that dropped support for creating new angular applicaplications with the .sass extension (#13444) conflicted with the pull request to only support known style extensions (#13470).

This pull request changes the referenced extension for the sass language to the correct '.scss' ending.

closes #13574

This pull request changes the referenced extension for the sass language to the correct '.scss' ending.

closes angular#13574
@alan-agius4
Copy link
Collaborator

Hi, thanks for your contribution. The value you amended is correct, as the name there is not for the file extension but rather the predecessor name, and scss is not

The issue that you are trying to solve has already been addressed in #13552

@alan-agius4 alan-agius4 closed this Feb 6, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng new --style=sass generates scss files
3 participants