Skip to content

ng new --style=sass generates scss files #13574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frankadrian opened this issue Feb 1, 2019 · 5 comments
Closed

ng new --style=sass generates scss files #13574

frankadrian opened this issue Feb 1, 2019 · 5 comments

Comments

@frankadrian
Copy link

🐞 Bug report

Command (mark with an x)

- [x] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?

Did not test it on versions prior to 7.3.0

Description

When generating a new app and selecting sass from the prompt, scss files are generated.
Also the angular.json file tries to reference styles.sass which does not exist.

🔬 Minimal Reproduction

ng new app
routing -> no
styles -> sass

🔥 Exception or Error

No Error, but when running `ng serve´ inside newly generated app it thows this error:


ERROR in multi ./src/styles.sass
Module not found: Error: Can't resolve '/Users/frank/Development/ng-test/src/styles.sass' in '/Users/frank/Development/ng-test'
ℹ 「wdm」: Failed to compile.

🌍 Your Environment



     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/


Angular CLI: 7.3.0
Node: 8.11.4
OS: darwin x64
Angular:
...

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.13.0
@angular-devkit/core         7.3.0
@angular-devkit/schematics   7.3.0
@schematics/angular          7.3.0
@schematics/update           0.13.0
rxjs                         6.3.3
typescript                   3.2.2

screenshot 2019-02-01 at 20 47 47

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Feb 2, 2019

This is the indented behaviour see #13444 for more context.

@frankadrian
Copy link
Author

Thanks for your response @alan-agius4.
What about the angular.json file; The main stylesheet, styles.scss, is referenced as styles.sass which leads to an error when trying to run or build the app.

@ageisen2000
Copy link

ageisen2000 commented Feb 4, 2019

@alan-agius4 how is a broken template intended behavior? I've never had to edit files before being able to serve a brand new template before

akehir added a commit to akehir/angular-cli that referenced this issue Feb 6, 2019
This pull request changes the referenced extension for the sass language to the correct '.scss' ending.

closes angular#13574
@alan-agius4
Copy link
Collaborator

@ageisen2000, no that is indeed a bug and has been addressed in #13552

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants