Automatic desktop notifications on build errors

[jkuri]

I modified a TypeScript compiler to show notifications similar like grunt-notify.
This can come handy when developing an application.
Note that notifications are disabled by default and can be enabled in config/angular-cli.json file.

[filipesilva]

I hadn't given much thought to this functionality but it seems to be useful and unobtrusive on the rest of the project. Plus since the cli is taking care of notifications, it's hard to sometimes know from within the editor wether or not the build is broken.

So lgtm. Could you rebase on top of master?

[jkuri]

@filipesilva sure, rebased.

[Brocco]

This also looks pretty good, although instead of having the configuration values stored in a new config file, please add an attribute in the root object in package.json to store this information.

I would suggest a name to match this repo/package angular-cli and pull the value from that file.

Also I do not think it makes sense to have the audio notification turned on by default and it that'd make a good value to be pulled from the configuration.

package.json

{
  "angular-cli": {
    "notifications": {
      "enabled": true,
      "playSound": false
    }
  }
}

[jkuri]

@Brocco yes, you are right, there's no need for additional config file. Will modify it later tonight and make a commit.

[filipesilva]

I hadn't even noticed the sound, but I'm totally with @Brocco on this one. It would drive me crazy.

[jkuri]

@filipesilva haha. I made a commit as @Brocco suggested btw.

[filipesilva]

@Brocco seems happy with it so I am happy to merge it. I noticed hansl was asking you on the other PR to squash the commits into one, and I forgot to ask you that myself.

To keep the history tidy, may I suggest you name the single commit feat(build): add desktop notifications ?

[jkuri]

Done. Added name to commit as you suggested.

[filipesilva]

And it's in! Thanks @jkuri !

[jkuri]

np, thank you.

[hansl]

This PR will be reverted when we upgrade the broccoli files to the latest ones from angular/angular. If you want to add new features to the standard broccoli flow, do it in angular-app.js or do it in angular/angular.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}